Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Android api 33 #825

Closed
ohtanzcom opened this issue Feb 28, 2023 · 12 comments · Fixed by #844
Closed

Support for Android api 33 #825

ohtanzcom opened this issue Feb 28, 2023 · 12 comments · Fixed by #844
Milestone

Comments

@ohtanzcom
Copy link

Feature Request

Motivation Behind Feature

READ_EXTERNAL_STORAGE and WRITE_EXTERNAL_STORAGE used in CameraLauncher.java from API 33 are no longer available.
Instead, fine-grained permission controls such as READ_MEDIA_IMAGES are required.

https://developer.android.com/about/versions/13/behavior-changes-13

Feature Description

READ_EXTERNAL_STORAGE and WRITE_EXTERNAL_STORAGE always return denied, so these need to be corrected.

Alternatives or Workarounds

@breautek
Copy link
Contributor

We do have a PR #814 for this, but is ultimately waiting on the next major release of cordova-android for API 33 support, so that we can use the newer permissions.

However you can likely test the PR today with cordova-android@11 by using the following preferences:

<preference name="android-buildToolsVersion" value="33.0.0" />
<preference name="android-compileSdkVersion" value="33" />

You'll also need use Android's SDK Manager to install API 33 platform and Android 33 Build Tools. You may also need to update your PATH environment variable to include $ANDROID_HOME/build-tools/33.0.0/, replacing 32.0.0 if present.

I however am not sure if cordova-android@11 will build on API 33 without further changes.

@breautek breautek added this to the 7.0.0 milestone Feb 28, 2023
@ohtanzcom
Copy link
Author

I am using API33 on cordova10 and was unable to get the photo taken by the activated camera and got an error, so I commented the part of the screenshot and forced it to work around the permission error.
2023-03-01 10_47_23-Clipboard

@jkenjarCR
Copy link

We do have a PR #814 for this, but is ultimately waiting on the next major release of cordova-android for API 33 support, so that we can use the newer permissions.

However you can likely test the PR today with cordova-android@11 by using the following preferences:

<preference name="android-buildToolsVersion" value="33.0.0" />
<preference name="android-compileSdkVersion" value="33" />

You'll also need use Android's SDK Manager to install API 33 platform and Android 33 Build Tools. You may also need to update your PATH environment variable to include $ANDROID_HOME/build-tools/33.0.0/, replacing 32.0.0 if present.

I however am not sure if cordova-android@11 will build on API 33 without further changes.

how do i install the PR? kind of important information is it not?

@DevEdward666
Copy link

DevEdward666 commented May 25, 2023

cordova-android 12 is out any update?
https://www.npmjs.com/package/cordova-android

@scotthmusson
Copy link

Now that Cordova Android 12 is out can we expect the fix for this to be released soon? Any ETA on this release? Appreciate your help!

@brunoalex
Copy link

we need this fix

@iKrishnaSahu
Copy link

iKrishnaSahu commented Jun 29, 2023

Upgraded my app to Cordova Android 12 and found out that camera plugin is not working.
Downgrading it back.

+1 We need this fix

Update -
Workaround - #826 (comment)

@alexisGandar
Copy link

+1 need the fix

@andavistw
Copy link

+1 also need the fix

@sonikdesign
Copy link

+1 need the fix please

@Sotatek-HaiNguyen3
Copy link

May I ask why you can't merge pull request #814 , is there any problem?
Do you have any plans to merge this pull request?

@clarklight
Copy link

Can we merge it into version 7.0.0? A few of us has tested the fix in the other thread, it works on Android 13 for me, and another person.

#840 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet