Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

GH-68 (ios): Support for disabling 3D Touch link previews #69

Merged
merged 2 commits into from
Dec 19, 2018

Conversation

nilsd
Copy link
Contributor

@nilsd nilsd commented Nov 20, 2018

Platforms affected

  • iOS

What does this PR do?

  • Adding support for a new preference - Allow3DTouchLinkPreview - if set to false disables link preview popups when 3D touching links in iOS.

Example usage in config.xml:

<preference name="Allow3DTouchLinkPreview" value="false" />

What testing has been done on this change?

  • Manually tested setting the preference to both true and false and omitting it.

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

closes #68

Copy link
Member

@janpio janpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some documentation to the README. Thanks.

Instructions on how to use preference Allow3DTouchLinkPreview
@janpio
Copy link
Member

janpio commented Nov 20, 2018

For the navigation there is this method .allowsBackForwardNavigationGestures() to enable/disable this dynamically. Do you think this might be useful for the 3d touch preview stuff as well?

@nilsd
Copy link
Contributor Author

nilsd commented Nov 20, 2018

For the navigation there is this method .allowsBackForwardNavigationGestures() to enable/disable this dynamically. Do you think this might be useful for the 3d touch preview stuff as well?

Yeah I thought I might try that as well, let's keep the PR open until I do.

@nilsd
Copy link
Contributor Author

nilsd commented Nov 27, 2018

@janpio Might be useful but I don't have time to implement it right now. I may submit another PR to add that feature soon.

@janpio
Copy link
Member

janpio commented Nov 27, 2018

Awesome.

Can someone else please use this branch to test this new feature so it is tested by multiple people?

Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS: Preference for disabling 3D touch link previews
3 participants