Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag elixir tests into meaningful groups #1885

Closed
iilyak opened this issue Jan 29, 2019 · 8 comments
Closed

Tag elixir tests into meaningful groups #1885

iilyak opened this issue Jan 29, 2019 · 8 comments

Comments

@iilyak
Copy link
Contributor

iilyak commented Jan 29, 2019

Elixir has ability to tag test cases. Which means we can split tests into categories and run them in the sensible order. We would need to do some leg work to make it happen, but it is doable. We want to fail fast so we would run the group of tests in the following order:

  • single_node
  • degraded_cluster
  • cluster
  • performance
  • property_based
@wohali
Copy link
Member

wohali commented Jan 29, 2019

poke @van-mronov @jjrodrig does this issue interest either of you?

@van-mronov
Copy link
Contributor

@wohali @iilyak sure, I'd gladly deal with this task.

@van-mronov
Copy link
Contributor

@wohali @iilyak so, do we already know which tests are single_node, etc?

@iilyak
Copy link
Contributor Author

iilyak commented Feb 1, 2019

I don't know from the top of my head but it is easy to figure out.

  1. one of the signs for tags is if we start tests differently https://github.com/apache/couchdb/blob/master/Makefile#L211
  2. tests which require single node setup fail when dev/lib is present
  • run dev cluster for few seconds (we just need it let to join) dev/run --admin=adm:pass
  • stop the cluster CTRL+C
  • modify Makefile so devclean is not called for elixir tests
  • run elixir tests and check which ones fail
    • make elixir
    • make elixir-cluster-without-quorum
    • make elixir-cluster-with-quorum

@wohali
Copy link
Member

wohali commented Feb 6, 2019

I'm a little nervous about this proposal just pushing tests into a flaky category and then never being examined.

Who is volunteering to clean up these tests and ensure we don't ignore them forever?

@wohali
Copy link
Member

wohali commented Jun 25, 2020

@jjrodrig @dottorblaster Either of you still interested in taking this on?

@dottorblaster
Copy link
Member

@wohali absolutely!

@nickva
Copy link
Contributor

nickva commented Nov 13, 2023

This was implemented in #3110

However we ended up using hard-coded suites instead it seems.

@nickva nickva closed this as completed Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants