Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arrow type bindings #173

Merged
merged 17 commits into from
Feb 13, 2023
Merged

Arrow type bindings #173

merged 17 commits into from
Feb 13, 2023

Conversation

jdye64
Copy link
Contributor

@jdye64 jdye64 commented Feb 6, 2023

Which issue does this PR close?

Closes #172

@andygrove
Copy link
Member

LGTM overall, but can we return Err rather than use todo! and unimplemented!?

@jdye64
Copy link
Contributor Author

jdye64 commented Feb 9, 2023

@andygrove just saw this. Yes. Question, what kind of error do we want to thrown when something happens like this you think? Should we add one for "UnImplemented"?

@andygrove
Copy link
Member

@andygrove just saw this. Yes. Question, what kind of error do we want to thrown when something happens like this you think? Should we add one for "UnImplemented"?

Yes, in the core DataFusion crate we have DataFusionError::NotImplemented(String) so would be good to be consistent with that.

@jdye64
Copy link
Contributor Author

jdye64 commented Feb 10, 2023

CI is failing due to rate limits trying to consume the protoc github actions plugin. Will make another commit later in hopes this is resolved. If this continues to happen we might want to investigate moving to a manual protoc installation. That is much more messy but might be necessary if this keeps happening. Feel like that should happen in another PR however.

src/sql/exceptions.rs Outdated Show resolved Hide resolved
src/common/data_type.rs Outdated Show resolved Hide resolved
src/common/data_type.rs Outdated Show resolved Hide resolved
@martin-g
Copy link
Member

CI is failing due to rate limits trying to consume the protoc github actions plugin

See arduino/setup-protoc#63 (comment)

@andygrove andygrove merged commit a53ce95 into apache:main Feb 13, 2023
@jdye64 jdye64 deleted the arrow_type_bindings branch February 13, 2023 22:14
@andygrove andygrove added the enhancement New feature or request label Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a "mapping" struct for types
3 participants