Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop copying LogicalPlan and Exprs in CommonSubexprEliminate #10211

Closed
alamb opened this issue Apr 24, 2024 · 5 comments
Closed

Stop copying LogicalPlan and Exprs in CommonSubexprEliminate #10211

alamb opened this issue Apr 24, 2024 · 5 comments

Comments

@alamb
Copy link
Contributor

alamb commented Apr 24, 2024

Is your feature request related to a problem or challenge?

As part of making the planner faster, we are updating the passes to avoid copying LogicalPlan and Expr (see #9637)

Recent profiling (#9637 (comment)) shows that a non trivial amount of plan time happens in CommonSubexprEliminate

Describe the solution you'd like

I would like to reduce the amount of copying in this pass that it no longer appears in profiling traces

Describe alternatives you've considered

No response

Additional context

No response

@alamb alamb changed the title CommonSubexprEliminate Stop copying LogicalPlan and Exprs in CommonSubexprEliminate Apr 24, 2024
@alamb
Copy link
Contributor Author

alamb commented Apr 24, 2024

I believe @peter-toth is working on this one

@peter-toth
Copy link
Contributor

I am, but how this issue relates to #9873? Are they duplicates?

@alamb
Copy link
Contributor Author

alamb commented Apr 24, 2024

I am, but how this issue relates to #9873? Are they duplicates?

Good call -- I think they are dupes. Closing this one

@alamb alamb closed this as completed Apr 24, 2024
@alamb alamb reopened this Apr 24, 2024
@peter-toth
Copy link
Contributor

@alamb, why did you reopen this?

@alamb
Copy link
Contributor Author

alamb commented May 1, 2024

@alamb, why did you reopen this?

I am not sure. Sorry about that

@alamb alamb closed this as completed May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants