Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support named placeholders wherever numeric ones are allowed #11021

Open
zcourts opened this issue Jun 20, 2024 · 0 comments
Open

Support named placeholders wherever numeric ones are allowed #11021

zcourts opened this issue Jun 20, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@zcourts
Copy link

zcourts commented Jun 20, 2024

Is your feature request related to a problem or challenge?

The work done in #8245 moved this forward. I'd like to request/suggest expanding it to cover the two cases explicitly ruled out by the original work.

It makes just as much sense when inserting/updating/deleting to use named placeholders as it does in select.
We and our customers are commonly writing inserts that have 5, 10+ numeric placeholders and it is harder to work with/keep track of and have lead to several typo/bugs that named placeholders would have made less likely, if not ruled out altogether.

Describe the solution you'd like

Add the ability to use named placeholders - from what I can see the handling of insert_into_plan can be made to be the same as it was in the PR be replacing the current impl https://github.com/apache/datafusion/blob/main/datafusion/sql/src/statement.rs#L1428 with usage of https://github.com/Asura7969/arrow-datafusion/blob/6480020e695ebbe2b81e8971c3ee0e9e7ec124b0/datafusion/common/src/param_value.rs#L68

Describe alternatives you've considered

No response

Additional context

No response

@zcourts zcourts added the enhancement New feature or request label Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant