Minor: Convert Count's name to lowercase
#11028
Conversation
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
github-actions
bot
added
sql
Signed-off-by: jayzhan211 <jayzhan211@gmail.com>
jayzhan211
force-pushed
the
lowercase-count
branch
from
74fe099
to
23bcf39
Compare
jayzhan211
changed the title
Count's name to lowercaseCount's name to lowercase
There was a problem hiding this comment.
Thank you @jayzhan211
I merged up from main with this branch to resolve a conflict
| @@ -1986,7 +1986,7 @@ mod tests { | |||
|
|
|||
| assert_batches_sorted_eq!( | |||
| ["+----+-----------------------------+-----------------------------+-----------------------------+-----------------------------+-------------------------------+----------------------------------------+", | |||
| "| c1 | MIN(aggregate_test_100.c12) | MAX(aggregate_test_100.c12) | AVG(aggregate_test_100.c12) | sum(aggregate_test_100.c12) | COUNT(aggregate_test_100.c12) | COUNT(DISTINCT aggregate_test_100.c12) |", | |||
| "| c1 | MIN(aggregate_test_100.c12) | MAX(aggregate_test_100.c12) | AVG(aggregate_test_100.c12) | sum(aggregate_test_100.c12) | count(aggregate_test_100.c12) | count(DISTINCT aggregate_test_100.c12) |", | |||
There was a problem hiding this comment.
@jayzhan211 are we planning to align also MIN, MAX, AVG to be lowercase?
There was a problem hiding this comment.
Starts from #10695, I plan to rename all the UDAF to lowercase to have a consistent naming
There was a problem hiding this comment.
Thanks @jayzhan211 I personally prefer function names to be uppercase, its more readable imho, but what is more important all of it has to be the same case to avoid a mess. Are you planning to convert all others to lowercase as well?
I think the case is being converted as part of the migration to UDAF -- for example #10964 |
We can introduce config setting to have upper case for display, but lowercase for internal use (we get the function or compare with it's name) if you hope so. |
* push down non-unnest only Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * add doc Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * to lowercase Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * fix tpch Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * Update test * fix test Signed-off-by: jayzhan211 <jayzhan211@gmail.com> --------- Signed-off-by: jayzhan211 <jayzhan211@gmail.com> Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
* push down non-unnest only Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * add doc Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * to lowercase Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * fix tpch Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * Update test * fix test Signed-off-by: jayzhan211 <jayzhan211@gmail.com> --------- Signed-off-by: jayzhan211 <jayzhan211@gmail.com> Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
* push down non-unnest only Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * add doc Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * to lowercase Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * fix tpch Signed-off-by: jayzhan211 <jayzhan211@gmail.com> * Update test * fix test Signed-off-by: jayzhan211 <jayzhan211@gmail.com> --------- Signed-off-by: jayzhan211 <jayzhan211@gmail.com> Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Which issue does this PR close?
Part of #10695
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?