Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Left/Full join of the NestedLoopJoin requires the RHS(outer table) to be a FusedStream #12187

Closed
YjyJeff opened this issue Aug 27, 2024 · 0 comments · Fixed by #12189
Closed
Labels
bug Something isn't working

Comments

@YjyJeff
Copy link
Contributor

YjyJeff commented Aug 27, 2024

Describe the bug

According to the code, when the outer table returns None for the first time, the NestedLoopJoinStream may return Some(RecordBatch) to produce the result for the unmatched rows. Therefore, the NestedLoopJoinStream is not exhausted and will be polled again. However, the next poll will also poll the outer_table, when the outer_table does not support the FusedStream, it may panic.

To fix the bug, we could require the execute method returns a FusedStream or add a wrapper for the outer_table

To Reproduce

No response

Expected behavior

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant