Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hooks for temporary tables in the catalog #12463

Closed
hailelagi opened this issue Sep 14, 2024 · 2 comments · Fixed by #12561
Closed

hooks for temporary tables in the catalog #12463

hailelagi opened this issue Sep 14, 2024 · 2 comments · Fixed by #12561
Labels
enhancement New feature or request

Comments

@hailelagi
Copy link
Contributor

hailelagi commented Sep 14, 2024

Is your feature request related to a problem or challenge?

While trying to return an explicit error to clarify the semantics of temporary tables in #12363, it was suggested that it might be a good idea to semantically distinguish temporary tables in the catalog, while strictly speaking this behaviour is/already exists in that DF's tables support this behaviour.

Describe the solution you'd like

I would like to clearly define the semantics of a temporary table in the catalog.

Describe alternatives you've considered

No response

Additional context

No response

@hailelagi hailelagi added the enhancement New feature or request label Sep 14, 2024
@alamb
Copy link
Contributor

alamb commented Sep 16, 2024

How about adding a flag on the appropriate DdlStatement

https://docs.rs/datafusion/latest/datafusion/logical_expr/enum.DdlStatement.html

So for example, that would mean adding a temporary flag to structures like CreateMemoryTable, CreateExternalTable, etc

https://docs.rs/datafusion/latest/datafusion/logical_expr/struct.CreateMemoryTable.html

If we wanted we could plumb that information into the memory catalog implementation that comes with DataFusion or we could potentially simply error if it appears (and let users of DataFusion define the semantics)

@hailelagi hailelagi changed the title Proposal: provide hooks for temporary tables in the catalog hooks for temporary tables in the catalog Sep 19, 2024
@hailelagi
Copy link
Contributor Author

take

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants