Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ballista] Fix integration test script #4

Closed
andygrove opened this issue Apr 18, 2021 · 0 comments · Fixed by #5
Closed

[Ballista] Fix integration test script #4

andygrove opened this issue Apr 18, 2021 · 0 comments · Fixed by #5

Comments

@andygrove
Copy link
Member

Now that Ballista has dependencies on DataFusion in the same repo, the integration test scripts and Dockerfile need updating to add DataFusion source into the docker image.

We may want to add Ballista to the default workspace as part of this fix.
@andygrove andygrove mentioned this issue Apr 18, 2021
Merged
houqp pushed a commit to jorgecarleitao/arrow-datafusion that referenced this issue Sep 18, 2021
@yjshen @houqp
Fix DataFusion test and try to make ballista compile (apache#4)
843fbe6 
* wip

* more

* Make scalar.rs compile

* Fix various compilation error due to API difference

* Make datafusion core compile

* fmt

* wip

* wip: compile ballista

* Pass all datafusion tests

* Compile ballista
EricJoy2048 added a commit to EricJoy2048/arrow-datafusion that referenced this issue Mar 2, 2022
@EricJoy2048
Add print (apache#4)
edffe28 
* 添加更多的日志打印
alamb pushed a commit that referenced this issue Aug 9, 2022
Upgrade to arrow 20.0.0 (but no change to object_store), including `p…
3eb55e9 
…rost`, and `tonic` (#3083)

* Upgrade arrow

fix decimal (#4)

Fix human error

Patch crates io to fix build (#5)

* fix decimal

* patch crate versions

Patch objectstore

Test in CI

Undo override?

Fix more errors

Fix last error?

Formatting

Clippy

Fixes

Fix refs

Able to get session context, but JDBC driver hung

Upgrade to arrow 20

Upgrade to RC2

Formatting

Fix some imports

Install protoc

Try platform agnostic path

Debug in CI :(

Debug in CI :(

Debug in CI :(

Not worth it, just separate builds

Variables

Fixes

Fix windows?

Fix windows?

Hackily fix windows

Down to 1 failure

Fix protoc

All? tests pass

Formatting

* Fix remaining tests

* Clippy

* Update docs for Windows

* Try with old objectstore

* Revert path "fixes" that broke windows

* Update to arrow 20
andygrove added a commit that referenced this issue Jan 12, 2023
@andygrove @Dandandan
@JanKaul @nseekhao @waynexia
Add datafusion-substrait crate (#4543)
0d27fcb 
* Initial commit

* initial commit

* failing test

* table scan projection

* closer

* test passes, with some hacks

* use DataFrame (#2)

* update README

* update dependency

* code cleanup (#3)

* Add support for Filter operator and BinaryOp expressions (#4)

* GitHub action (#5)

* Split code into producer and consumer modules (#6)

* Support more functions and scalar types (#7)

* Use substrait 0.1 and datafusion 8.0 (#8)

* use substrait 0.1

* use datafusion 8.0

* update datafusion to 10.0 and substrait to 0.2 (#11)

* Add basic join support (#12)

* Added fetch support (#23)

Added fetch to consumer

Added limit to producer

Added unit tests for limit

Added roundtrip_fill_none() for testing when None input can be converted to 0

Update src/consumer.rs

Co-authored-by: Andy Grove <andygrove73@gmail.com>

Co-authored-by: Andy Grove <andygrove73@gmail.com>

* Upgrade to DataFusion 13.0.0 (#25)

* Add sort consumer and producer (#24)

Add consumer

Add producer and test

Modified error string

* Add serializer/deserializer (#26)

* Add plan and function extension support (#27)

* Add plan and function extension support

* Removed unwraps

* Implement GROUP BY (#28)

* Add consumer, producer and tests for aggregate relation

Change function extension registration from absolute to relative anchor
(reference)

Remove operator to/from reference

* Fixed function registration bug

* Add test

* Addressed PR comments

* Changed field reference from mask to direct reference (#29)

* Changed field reference from masked reference to direct reference

* Handle unsupported case (struct with child)

* Handle SubqueryAlias (#30)

Fixed aggregate function register bug

* Add support for SELECT DISTINCT (#31)

Add test case

* Implement BETWEEN (#32)

* Add case (#33)

* Implement CASE WHEN

* Add more case to test

* Addressed comments

* feat: support explicit catalog/schema names in ReadRel (#34)

* feat: support explicit catalog/schema names in ReadRel

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>

* fix: use re-exported expr crate

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>

* move files to subfolder

* RAT

* remove rust.yaml

* revert .gitignore changes

* tomlfmt

* tomlfmt

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Co-authored-by: Daniël Heres <danielheres@gmail.com>
Co-authored-by: JanKaul <jankaul@mailbox.org>
Co-authored-by: nseekhao <37189615+nseekhao@users.noreply.github.com>
Co-authored-by: Ruihang Xia <waynestxia@gmail.com>
@Omega359 Omega359 mentioned this issue Feb 7, 2024
Closed
alamb added a commit that referenced this issue Aug 9, 2024
@peter-toth @alamb
Make CommonSubexprEliminate top-down like (#11683)
b5d7931 
* Make `CommonSubexprEliminate` top-down like

* fix top-down recursion, fix unit tests to use real a Optimizer to verify behavior on plans

* Extract result of `find_common_exprs` into a struct (#4)

* Extract the result of find_common_exprs into a struct

* Make naming consistent

---------

Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Ballista] Fix Ballista IT andygrove/datafusion
1 participant
@andygrove