Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hard-coded Ballista version from scripts #32

Closed
andygrove opened this issue Apr 22, 2021 · 2 comments · Fixed by #49
Closed

Remove hard-coded Ballista version from scripts #32

andygrove opened this issue Apr 22, 2021 · 2 comments · Fixed by #49
Labels
ballista enhancement New feature or request

Comments

@andygrove
Copy link
Member

Ballista has some scripts for building Docker images and they have hard-coded versions, such as:

BALLISTA_VERSION=0.4.2-SNAPSHOT

We should change the scripts to get the version number from cargo instead. There are probably cargo utilities available to help with this.
@andygrove andygrove added enhancement New feature or request ballista labels Apr 22, 2021
@andygrove andygrove mentioned this issue Apr 22, 2021
Merged
@msathis
Copy link
Contributor

msathis commented Apr 22, 2021

I can take this 👍

@msathis
Copy link
Contributor

msathis commented Apr 22, 2021

I'll work on this once #23 is merged

msathis referenced this issue in msathis/arrow-datafusion Apr 24, 2021
@msathis
Remove hard coded ballista versions. Fixes #32
4a99347
@msathis msathis mentioned this issue Apr 24, 2021
Merged
jorgecarleitao pushed a commit that referenced this issue Apr 25, 2021
@msathis
Remove hard coded ballista versions. Fixes #32 (#49)
fa99979 
Co-authored-by: Sathis Kumar <sathis.kumar@udemy.com>
EricJoy2048 pushed a commit to argoengine/arrow-datafusion that referenced this issue Feb 24, 2022
Merge branch 'add_show_tables' into 'master'
cf8fe54 
添加show tables, show columns 功能

Closes apache#31 and apache#32

See merge request noah/argo_engine!68
andygrove added a commit that referenced this issue Jan 12, 2023
@andygrove @Dandandan
@JanKaul @nseekhao @waynexia
Add datafusion-substrait crate (#4543)
0d27fcb 
* Initial commit

* initial commit

* failing test

* table scan projection

* closer

* test passes, with some hacks

* use DataFrame (#2)

* update README

* update dependency

* code cleanup (#3)

* Add support for Filter operator and BinaryOp expressions (#4)

* GitHub action (#5)

* Split code into producer and consumer modules (#6)

* Support more functions and scalar types (#7)

* Use substrait 0.1 and datafusion 8.0 (#8)

* use substrait 0.1

* use datafusion 8.0

* update datafusion to 10.0 and substrait to 0.2 (#11)

* Add basic join support (#12)

* Added fetch support (#23)

Added fetch to consumer

Added limit to producer

Added unit tests for limit

Added roundtrip_fill_none() for testing when None input can be converted to 0

Update src/consumer.rs

Co-authored-by: Andy Grove <andygrove73@gmail.com>

Co-authored-by: Andy Grove <andygrove73@gmail.com>

* Upgrade to DataFusion 13.0.0 (#25)

* Add sort consumer and producer (#24)

Add consumer

Add producer and test

Modified error string

* Add serializer/deserializer (#26)

* Add plan and function extension support (#27)

* Add plan and function extension support

* Removed unwraps

* Implement GROUP BY (#28)

* Add consumer, producer and tests for aggregate relation

Change function extension registration from absolute to relative anchor
(reference)

Remove operator to/from reference

* Fixed function registration bug

* Add test

* Addressed PR comments

* Changed field reference from mask to direct reference (#29)

* Changed field reference from masked reference to direct reference

* Handle unsupported case (struct with child)

* Handle SubqueryAlias (#30)

Fixed aggregate function register bug

* Add support for SELECT DISTINCT (#31)

Add test case

* Implement BETWEEN (#32)

* Add case (#33)

* Implement CASE WHEN

* Add more case to test

* Addressed comments

* feat: support explicit catalog/schema names in ReadRel (#34)

* feat: support explicit catalog/schema names in ReadRel

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>

* fix: use re-exported expr crate

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>

* move files to subfolder

* RAT

* remove rust.yaml

* revert .gitignore changes

* tomlfmt

* tomlfmt

Signed-off-by: Ruihang Xia <waynestxia@gmail.com>
Co-authored-by: Daniël Heres <danielheres@gmail.com>
Co-authored-by: JanKaul <jankaul@mailbox.org>
Co-authored-by: nseekhao <37189615+nseekhao@users.noreply.github.com>
Co-authored-by: Ruihang Xia <waynestxia@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ballista enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Ballista] Remove hard coded ballista versions in scripts msathis/arrow-datafusion
2 participants
@andygrove @msathis