Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ballista] Remove hard coded ballista versions in scripts #49

Merged
merged 1 commit into from
Apr 25, 2021

Conversation

msathis
Copy link
Contributor

@msathis msathis commented Apr 24, 2021

Which issue does this PR close?

Closes #32 .

Rationale for this change

Versions are hardcoded in too many places.

What changes are included in this PR?

Greps version from ballista/rust/core/Cargo.toml and exports it, so other scripts can use it.

Are there any user-facing changes?

N/A

@msathis msathis changed the title Remove hard coded ballista versions. [Ballista] Remove hard coded ballista versions in scripts Apr 24, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #49 (4a99347) into master (3cb83fe) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #49   +/-   ##
=======================================
  Coverage   76.24%   76.24%           
=======================================
  Files         134      134           
  Lines       23051    23051           
=======================================
  Hits        17576    17576           
  Misses       5475     5475           
Impacted Files Coverage Δ
benchmarks/src/bin/tpch.rs 35.15% <0.00%> (ø)
benchmarks/src/bin/nyctaxi.rs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cb83fe...4a99347. Read the comment docs.

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I tested locally and integration tests passed.

@jorgecarleitao jorgecarleitao merged commit fa99979 into apache:master Apr 25, 2021
@msathis msathis deleted the remove-hardcoded-version branch April 25, 2021 05:40
@houqp houqp added the development-process Related to development process of arrow-datafusion label Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of arrow-datafusion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove hard-coded Ballista version from scripts
6 participants