Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timediff function #1505

Merged
merged 2 commits into from
Jul 23, 2019
Merged

Add timediff function #1505

merged 2 commits into from
Jul 23, 2019

Conversation

HangyuanLiu
Copy link
Contributor

@HangyuanLiu HangyuanLiu commented Jul 18, 2019 •
edited
Loading

Add timediff function

#1428

@chenhao7253886
Copy link
Contributor

I think that you need't import a new udf type to implement timediff.

imay
imay reviewed Jul 19, 2019
View reviewed changes
gensrc/script/gen_functions.py Outdated
@@ -552,6 +554,7 @@
'VARCHAR': 'string_val',
'DATE': 'datetime_val',
'DATETIME': 'datetime_val',
'TIME': 'datetime_val',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to use bigint_val

fe/src/main/java/org/apache/doris/analysis/IntLiteral.java Outdated
@@ -89,6 +91,11 @@ public IntLiteral(long longValue, Type type) throws AnalysisException {
}
// no need to check upper bound
break;
case TIME:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is not fit to add type TIME in IntLiteral

be/src/runtime/result_writer.cpp Outdated
@@ -105,7 +105,8 @@ Status ResultWriter::add_one_row(TupleRow* row) {
break;

case TYPE_DATE:
case TYPE_DATETIME: {
case TYPE_DATETIME:
case TYPE_TIME: {
char buf[64];
const DateTimeValue* time_val = (const DateTimeValue*)(item);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think use bigint to represent time in memory?

@HangyuanLiu HangyuanLiu force-pushed the add-timediff branch 2 times, most recently from 403f208 to 4fb06b4 Compare July 22, 2019 03:17
imay
imay reviewed Jul 22, 2019
View reviewed changes
be/src/exprs/literal.cpp Outdated
@@ -87,6 +87,11 @@ Literal::Literal(const TExprNode& node) :
_value.datetime_val.from_date_str(
node.date_literal.value.c_str(), node.date_literal.value.size());
break;
case TYPE_TIME:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reuse TYPE_DOUBLE

be/src/exprs/time_operators.h
public:
static void init();

static BooleanVal cast_to_boolean_val(FunctionContext*, const DoubleVal&);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can only support time to double and to string

be/src/runtime/raw_value.cpp Outdated
@@ -267,6 +267,7 @@ void RawValue::write(const void* value, void* dst, const TypeDescriptor& type, M
break;
}

case TYPE_TIME:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be the same as TYPE_DOUBLE

be/src/runtime/result_writer.cpp
@@ -104,6 +104,39 @@ Status ResultWriter::add_one_row(TupleRow* row) {
buf_ret = _row_buffer->push_double(*static_cast<double*>(item));
break;

case TYPE_TIME: {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can write a function to do this to avoid write this many times

fe/src/main/java/org/apache/doris/catalog/Function.java Outdated
@@ -480,6 +481,7 @@ public static String getUdfType(PrimitiveType t) {
case INT:
return "IntVal";
case BIGINT:
case TIME:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why BIGINT?

fe/src/main/java/org/apache/doris/catalog/PrimitiveType.java
@@ -480,6 +486,7 @@ public static boolean isImplicitCast(PrimitiveType type, PrimitiveType target) {
compatibilityMatrix[DECIMALV2.ordinal()][DECIMAL.ordinal()] = DECIMALV2;

compatibilityMatrix[HLL.ordinal()][HLL.ordinal()] = HLL;
compatibilityMatrix[TIME.ordinal()][TIME.ordinal()] = TIME;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should add more relation between time and other types

@HangyuanLiu HangyuanLiu force-pushed the add-timediff branch 7 times, most recently from e649d62 to 92d7b85 Compare July 23, 2019 03:56
imay
imay approved these changes Jul 23, 2019
View reviewed changes
Copy link
Contributor

@imay imay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imay imay merged commit 4aedaea into apache:master Jul 23, 2019
morningman pushed a commit to baidu-doris/incubator-doris that referenced this pull request Jul 28, 2019
@HangyuanLiu @morningman
Support TIME type and timediff function (apache#1505)
99c8280
morningman pushed a commit to baidu-doris/incubator-doris that referenced this pull request Jul 28, 2019
@HangyuanLiu @morningman
Support TIME type and timediff function (apache#1505)
292172c 
merge to apache-doris 0694b6a
@imay imay mentioned this pull request Sep 26, 2019
Closed
@HangyuanLiu HangyuanLiu deleted the add-timediff branch December 25, 2019 02:06
luwei16 pushed a commit to luwei16/incubator-doris that referenced this pull request Apr 7, 2023
@airborne12
[Chore](inverted index) change log level in inverted_index_reader (ap…
9bc55f7 
…ache#1505)
SWJTU-ZhangLei pushed a commit to SWJTU-ZhangLei/incubator-doris that referenced this pull request Jul 25, 2023
@airborne12 @gavinchou
[Chore](inverted index) change log level in inverted_index_reader (ap…
c8ae2d6 
…ache#1505)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imay imay imay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HangyuanLiu @chenhao7253886 @imay