Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](Nereids) fix bind having aggregate failed #32490

Merged
merged 3 commits into from
Mar 22, 2024
Merged

[fix](Nereids) fix bind having aggregate failed #32490

merged 3 commits into from
Mar 22, 2024

Conversation

924060929
Copy link
Contributor

Proposed changes

fix bind having aggregate failed, keep the behavior like mysql

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@924060929
Copy link
Contributor Author

run buildall

1 similar comment
@924060929
Copy link
Contributor Author

run buildall

@924060929 924060929 mentioned this pull request Mar 19, 2024
Merged
@924060929
Copy link
Contributor Author

run buildall

@wm1581066 wm1581066 added dev/2.0.x usercase Important user case type label need_more_review and removed usercase Important user case type label dev/2.0.x labels Mar 19, 2024
@924060929
Copy link
Contributor Author

run buildall

924060929 added a commit that referenced this pull request Mar 20, 2024
@924060929
[fix](Nereids) fix bind having aggregate failed (#32497)
b869fa7 
cherry from #32490
@924060929
Copy link
Contributor Author

run buildall

1 similar comment
@924060929
Copy link
Contributor Author

run buildall

@924060929
Copy link
Contributor Author

run buildall

1 similar comment
@924060929
Copy link
Contributor Author

run buildall

@github-actions GitHub Actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@924060929
Copy link
Contributor Author

run buildall

@924060929
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 38196 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9ec459992b954dcb0d6d17c216924ed5986645fa, data reload: false

------ Round 1 ----------------------------------
q1	17712	5000	4284	4284
q2	2371	155	151	151
q3	11029	1202	1222	1202
q4	10343	799	806	799
q5	7504	3041	3036	3036
q6	209	129	123	123
q7	1045	613	582	582
q8	9539	2059	2012	2012
q9	7442	6636	6572	6572
q10	9870	3368	3525	3368
q11	435	218	211	211
q12	390	205	194	194
q13	17792	2856	2834	2834
q14	244	215	208	208
q15	504	462	460	460
q16	466	352	353	352
q17	961	559	567	559
q18	7210	6534	6449	6449
q19	1569	1450	1497	1450
q20	546	273	246	246
q21	3556	2907	2804	2804
q22	344	306	300	300
Total cold run time: 111081 ms
Total hot run time: 38196 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4071	4090	4103	4090
q2	319	222	229	222
q3	2980	2894	2897	2894
q4	1859	1545	1608	1545
q5	5231	5269	5244	5244
q6	199	116	116	116
q7	2238	1859	1861	1859
q8	3164	3335	3286	3286
q9	8603	8596	8600	8596
q10	3730	3684	3733	3684
q11	542	435	438	435
q12	742	546	535	535
q13	16895	2836	2847	2836
q14	274	245	243	243
q15	481	442	444	442
q16	465	428	408	408
q17	1740	1493	1486	1486
q18	7472	7166	7081	7081
q19	1627	1510	1538	1510
q20	1886	1724	1713	1713
q21	4656	4704	4716	4704
q22	504	443	441	441
Total cold run time: 69678 ms
Total hot run time: 53370 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 181723 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9ec459992b954dcb0d6d17c216924ed5986645fa, data reload: false

query1	924	359	351	351
query2	7334	2003	1945	1945
query3	6708	216	221	216
query4	31434	20962	20680	20680
query5	4350	414	407	407
query6	270	173	169	169
query7	4618	300	290	290
query8	235	177	171	171
query9	9898	2281	2266	2266
query10	455	236	246	236
query11	14746	14478	14173	14173
query12	135	87	88	87
query13	1637	407	409	407
query14	11803	11210	10872	10872
query15	261	212	202	202
query16	8139	252	248	248
query17	1965	554	525	525
query18	2081	271	269	269
query19	274	148	148	148
query20	90	86	85	85
query21	198	124	128	124
query22	4644	4469	4438	4438
query23	32005	31105	31305	31105
query24	10703	2809	2796	2796
query25	625	378	384	378
query26	1481	152	153	152
query27	3075	343	350	343
query28	8141	1914	1908	1908
query29	935	664	628	628
query30	304	143	143	143
query31	937	731	721	721
query32	102	58	57	57
query33	776	265	255	255
query34	1073	476	478	476
query35	837	622	632	622
query36	993	889	866	866
query37	125	77	75	75
query38	3580	3432	3404	3404
query39	1440	1393	1402	1393
query40	210	123	111	111
query41	48	48	45	45
query42	102	95	97	95
query43	476	449	447	447
query44	1243	737	712	712
query45	283	256	262	256
query46	1103	671	674	671
query47	1653	1601	1614	1601
query48	437	357	352	352
query49	1139	344	342	342
query50	781	370	365	365
query51	6660	6625	6590	6590
query52	102	99	93	93
query53	345	279	280	279
query54	368	246	261	246
query55	84	76	82	76
query56	266	235	238	235
query57	1098	1019	1007	1007
query58	233	215	215	215
query59	2721	2585	2587	2585
query60	281	250	261	250
query61	113	109	110	109
query62	593	379	391	379
query63	305	274	285	274
query64	6584	3840	3622	3622
query65	3129	3022	3012	3012
query66	1437	354	358	354
query67	15077	14660	14714	14660
query68	8839	516	527	516
query69	628	383	388	383
query70	1333	1138	1201	1138
query71	499	289	290	289
query72	6505	2634	2475	2475
query73	1497	315	315	315
query74	7139	6617	6639	6617
query75	4257	2866	2887	2866
query76	4789	895	1013	895
query77	646	281	269	269
query78	10455	9662	9628	9628
query79	12780	526	516	516
query80	1848	389	399	389
query81	503	211	215	211
query82	737	201	201	201
query83	220	141	143	141
query84	281	77	76	76
query85	1411	325	309	309
query86	406	298	291	291
query87	3771	3520	3575	3520
query88	5314	2273	2264	2264
query89	502	359	373	359
query90	1930	172	170	170
query91	163	134	136	134
query92	62	47	46	46
query93	7370	487	474	474
query94	1186	176	177	176
query95	438	330	328	328
query96	591	282	274	274
query97	3051	2881	2897	2881
query98	229	211	220	211
query99	1205	747	747	747
Total cold run time: 316787 ms
Total hot run time: 181723 ms

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 9ec459992b954dcb0d6d17c216924ed5986645fa with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       21.9 seconds inserted 10000000 Rows, about 456K ops/s

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.27% (8728/24749)
Line Coverage: 27.09% (71473/263870)
Region Coverage: 26.32% (37076/140875)
Branch Coverage: 23.23% (18960/81624)
Coverage Report: http://coverage.selectdb-in.cc/coverage/dbf678d92e7224121b79e2ec82d2ea6ed702c745_dbf678d92e7224121b79e2ec82d2ea6ed702c745/report/index.html

@924060929
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 38030 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2d8f63716c6208c46540244b0f4029f7d48ed1f7, data reload: false

------ Round 1 ----------------------------------
q1	17960	4502	4237	4237
q2	2148	164	153	153
q3	11268	1169	1235	1169
q4	10443	816	797	797
q5	7596	3039	2985	2985
q6	215	129	130	129
q7	1067	625	607	607
q8	9958	2036	2026	2026
q9	7100	6511	6462	6462
q10	8336	3317	3512	3317
q11	436	223	224	223
q12	387	200	199	199
q13	17809	2867	2868	2867
q14	239	216	210	210
q15	502	459	451	451
q16	484	367	355	355
q17	964	538	592	538
q18	7320	6606	6464	6464
q19	3819	1464	1487	1464
q20	534	263	247	247
q21	3699	3015	2826	2826
q22	356	304	308	304
Total cold run time: 112640 ms
Total hot run time: 38030 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4176	4119	4066	4066
q2	338	230	236	230
q3	2977	2885	2859	2859
q4	1858	1559	1577	1559
q5	5235	5272	5256	5256
q6	197	119	120	119
q7	2257	1867	1875	1867
q8	3161	3323	3295	3295
q9	8563	8566	8627	8566
q10	3763	3644	3691	3644
q11	536	458	435	435
q12	753	549	560	549
q13	16898	2868	2879	2868
q14	280	251	268	251
q15	481	450	448	448
q16	459	405	424	405
q17	1748	1488	1475	1475
q18	7562	7360	7091	7091
q19	1615	1569	1545	1545
q20	1966	1697	1701	1697
q21	4734	4734	4715	4715
q22	532	494	437	437
Total cold run time: 70089 ms
Total hot run time: 53377 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 181825 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2d8f63716c6208c46540244b0f4029f7d48ed1f7, data reload: false

query1	918	365	344	344
query2	7396	2075	1975	1975
query3	6744	215	219	215
query4	31155	20748	20799	20748
query5	4306	403	413	403
query6	274	192	173	173
query7	4633	305	283	283
query8	236	170	190	170
query9	9929	2297	2287	2287
query10	448	246	245	245
query11	17130	14332	14570	14332
query12	136	85	87	85
query13	1627	413	412	412
query14	11230	10445	10534	10445
query15	252	208	196	196
query16	8132	266	268	266
query17	1919	592	541	541
query18	2070	293	292	292
query19	237	160	166	160
query20	92	93	90	90
query21	197	130	126	126
query22	4625	4430	4461	4430
query23	31791	31266	31159	31159
query24	10858	2830	2821	2821
query25	645	381	394	381
query26	1459	154	161	154
query27	3089	356	340	340
query28	8167	1867	1867	1867
query29	916	629	626	626
query30	301	152	149	149
query31	955	729	713	713
query32	94	67	61	61
query33	767	270	267	267
query34	1058	491	488	488
query35	833	596	600	596
query36	1010	889	870	870
query37	127	81	77	77
query38	3547	3406	3439	3406
query39	1427	1379	1396	1379
query40	217	118	112	112
query41	52	47	45	45
query42	111	98	98	98
query43	489	451	465	451
query44	1335	705	733	705
query45	277	266	279	266
query46	1066	713	698	698
query47	1653	1582	1618	1582
query48	440	367	361	361
query49	1129	338	347	338
query50	763	378	376	376
query51	6772	6631	6534	6534
query52	111	113	90	90
query53	347	281	274	274
query54	328	262	247	247
query55	83	83	77	77
query56	251	247	238	238
query57	1106	1024	1012	1012
query58	241	211	219	211
query59	2973	2760	2661	2661
query60	276	249	263	249
query61	119	116	119	116
query62	629	405	400	400
query63	307	280	280	280
query64	6901	4002	3863	3863
query65	3164	3059	3031	3031
query66	1411	348	342	342
query67	15157	14434	14439	14434
query68	9413	544	545	544
query69	674	401	380	380
query70	1359	1107	1102	1102
query71	536	279	282	279
query72	6729	2670	2517	2517
query73	1602	316	320	316
query74	6886	6594	6586	6586
query75	4548	2927	2940	2927
query76	6069	1002	930	930
query77	664	269	259	259
query78	10494	9609	9538	9538
query79	11728	533	534	533
query80	1692	412	395	395
query81	476	209	217	209
query82	351	210	202	202
query83	216	150	144	144
query84	291	80	78	78
query85	1139	341	316	316
query86	358	263	281	263
query87	3775	3546	3573	3546
query88	5466	2297	2301	2297
query89	471	380	364	364
query90	2023	181	181	181
query91	180	133	135	133
query92	66	54	48	48
query93	6184	503	487	487
query94	1327	183	180	180
query95	447	334	336	334
query96	608	264	266	264
query97	3028	2894	2854	2854
query98	249	212	211	211
query99	1006	755	745	745
Total cold run time: 318493 ms
Total hot run time: 181825 ms

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 2d8f63716c6208c46540244b0f4029f7d48ed1f7 with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          58 seconds loaded 1101869774 Bytes, about 18 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       21.2 seconds inserted 10000000 Rows, about 471K ops/s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@morrySnow morrySnow merged commit 10fd75e into apache:master Mar 22, 2024
27 of 30 checks passed
yiguolei pushed a commit that referenced this pull request Mar 22, 2024
@924060929 @Doris-Extras
[fix](Nereids) fix bind having aggregate failed (#32490)
6812b57 
fix bind having aggregate failed, keep the behavior like mysql
@924060929 924060929 mentioned this pull request Mar 22, 2024
Merged
924060929 added a commit that referenced this pull request Mar 22, 2024
@924060929
[fix](Nereids) fix bind having aggregate failed again (#32687)
eb75ea8 
follow up #32490

add more tests and fix some cases because some sqls are valid to mysql, but failed in doris
yiguolei pushed a commit that referenced this pull request Mar 24, 2024
@924060929 @Doris-Extras
[fix](Nereids) fix bind having aggregate failed again (#32687)
3d14d9e 
follow up #32490

add more tests and fix some cases because some sqls are valid to mysql, but failed in doris
@924060929 924060929 mentioned this pull request Apr 2, 2024
Merged
924060929 added a commit that referenced this pull request Apr 2, 2024
@924060929
[fix](Nereids) fix bind having aggregate failed again (#33148)
bd74462 
cherry from #32490 and #32687
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@924060929
[fix](Nereids) fix bind having aggregate failed (apache#32497)
a7d08ac 
cherry from apache#32490
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@924060929
[fix](Nereids) fix bind having aggregate failed again (apache#33148)
8e41b71 
cherry from apache#32490 and apache#32687
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@starocean999 starocean999 starocean999 approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.8-merged need_more_review reviewed usercase Important user case type label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@924060929 @doris-robot @starocean999 @morrySnow @wm1581066