Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix](Nereids) fix bind having aggregate failed again #32687

Merged
merged 2 commits into from
Mar 22, 2024
Merged

[fix](Nereids) fix bind having aggregate failed again #32687

merged 2 commits into from
Mar 22, 2024

Conversation

924060929
Copy link
Contributor

Proposed changes

follow up #32490

add more tests and fix some cases because some sqls are valid to mysql, but failed in doris

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@924060929
Copy link
Contributor Author

run buildall

@924060929
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 37437 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9fe4785fbb9591aacb26f7c4000911b7941b0185, data reload: false

------ Round 1 ----------------------------------
q1	17706	4208	4119	4119
q2	2105	157	148	148
q3	10590	1107	1165	1107
q4	10229	804	699	699
q5	7468	2946	2914	2914
q6	208	127	124	124
q7	1028	581	565	565
q8	9321	1970	1965	1965
q9	7215	6453	6429	6429
q10	8363	3345	3446	3345
q11	433	225	234	225
q12	449	196	196	196
q13	17808	2846	2871	2846
q14	246	209	198	198
q15	494	458	458	458
q16	483	366	361	361
q17	945	639	572	572
q18	7058	6435	6368	6368
q19	4136	1426	1464	1426
q20	535	256	261	256
q21	3586	2849	2822	2822
q22	345	295	294	294
Total cold run time: 110751 ms
Total hot run time: 37437 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4130	4074	4093	4074
q2	325	231	234	231
q3	2963	2798	2828	2798
q4	1843	1530	1575	1530
q5	5227	5255	5259	5255
q6	200	120	119	119
q7	2263	1860	1838	1838
q8	3133	3293	3268	3268
q9	8510	8498	8496	8496
q10	3697	3704	3684	3684
q11	547	447	442	442
q12	734	533	543	533
q13	16918	2853	2856	2853
q14	286	244	259	244
q15	492	453	466	453
q16	480	421	429	421
q17	1712	1499	1454	1454
q18	7400	7307	7094	7094
q19	1659	1538	1509	1509
q20	1912	1714	1693	1693
q21	4913	4590	4629	4590
q22	549	455	441	441
Total cold run time: 69893 ms
Total hot run time: 53020 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 180552 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9fe4785fbb9591aacb26f7c4000911b7941b0185, data reload: false

query1	940	369	343	343
query2	7402	2003	2013	2003
query3	6714	216	214	214
query4	31004	20574	20553	20553
query5	4398	400	494	400
query6	269	195	170	170
query7	4635	300	290	290
query8	228	166	167	166
query9	9268	2341	2331	2331
query10	558	247	267	247
query11	15163	14065	14054	14054
query12	135	84	89	84
query13	1623	429	411	411
query14	11878	10620	10953	10620
query15	260	205	188	188
query16	8178	275	272	272
query17	1917	578	547	547
query18	2101	293	277	277
query19	305	154	154	154
query20	91	86	85	85
query21	205	129	130	129
query22	4604	4459	4446	4446
query23	31869	30957	31107	30957
query24	10688	2800	2801	2800
query25	614	399	382	382
query26	1204	160	164	160
query27	2428	355	352	352
query28	7313	1939	1896	1896
query29	886	656	642	642
query30	304	153	151	151
query31	943	743	729	729
query32	89	57	59	57
query33	773	269	260	260
query34	1064	473	497	473
query35	815	605	624	605
query36	976	876	889	876
query37	128	75	79	75
query38	3586	3477	3430	3430
query39	1409	1412	1369	1369
query40	222	116	114	114
query41	49	47	47	47
query42	104	95	96	95
query43	495	447	467	447
query44	1158	720	731	720
query45	292	268	269	268
query46	1083	713	705	705
query47	1699	1596	1607	1596
query48	452	357	368	357
query49	1131	346	333	333
query50	750	386	378	378
query51	6704	6653	6497	6497
query52	108	94	94	94
query53	344	273	278	273
query54	321	249	245	245
query55	84	84	82	82
query56	282	255	243	243
query57	1067	1005	1019	1005
query58	238	217	218	217
query59	2698	2616	2455	2455
query60	302	253	274	253
query61	119	116	119	116
query62	614	401	396	396
query63	300	285	279	279
query64	5660	3781	3676	3676
query65	3069	2982	3000	2982
query66	879	349	332	332
query67	14880	14295	14202	14202
query68	8664	547	550	547
query69	630	383	383	383
query70	1261	1103	1173	1103
query71	515	282	283	282
query72	6883	2686	2505	2505
query73	737	325	322	322
query74	6997	6568	6647	6568
query75	4198	2862	2877	2862
query76	5207	880	864	864
query77	671	268	261	261
query78	10353	9663	9479	9479
query79	7998	518	512	512
query80	1421	393	385	385
query81	527	220	219	219
query82	865	205	194	194
query83	205	142	144	142
query84	289	78	77	77
query85	1494	337	315	315
query86	426	263	304	263
query87	3722	3501	3536	3501
query88	4563	2358	2349	2349
query89	509	363	368	363
query90	1984	174	171	171
query91	170	153	135	135
query92	60	50	50	50
query93	6666	505	497	497
query94	1127	188	182	182
query95	436	360	338	338
query96	592	266	270	266
query97	3055	2861	2869	2861
query98	234	210	209	209
query99	1107	742	775	742
Total cold run time: 305635 ms
Total hot run time: 180552 ms

@doris-robot
Copy link

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 9fe4785fbb9591aacb26f7c4000911b7941b0185 with default session variables
Stream load json:         19 seconds loaded 2358488459 Bytes, about 118 MB/s
Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      32 seconds loaded 861443392 Bytes, about 25 MB/s
Insert into select:       21.5 seconds inserted 10000000 Rows, about 465K ops/s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Mar 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions GitHub Actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@924060929 924060929 merged commit eb75ea8 into apache:master Mar 22, 2024
26 of 30 checks passed
@924060929 924060929 deleted the fix_bind_having branch March 22, 2024 12:39
yiguolei pushed a commit that referenced this pull request Mar 24, 2024
@924060929 @Doris-Extras
[fix](Nereids) fix bind having aggregate failed again (#32687)
3d14d9e 
follow up #32490

add more tests and fix some cases because some sqls are valid to mysql, but failed in doris
@924060929 924060929 mentioned this pull request Apr 2, 2024
Merged
924060929 added a commit that referenced this pull request Apr 2, 2024
@924060929
[fix](Nereids) fix bind having aggregate failed again (#33148)
bd74462 
cherry from #32490 and #32687
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@924060929
[fix](Nereids) fix bind having aggregate failed again (apache#33148)
8e41b71 
cherry from apache#32490 and apache#32687
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morrySnow morrySnow morrySnow approved these changes

@feiniaofeiafei feiniaofeiafei feiniaofeiafei approved these changes

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by one committer. dev/2.0.8-merged reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@924060929 @doris-robot @feiniaofeiafei @morrySnow @xiaokang