Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show total rows/avg row size in human readable format #16888

Closed
FrankChen021 opened this issue Aug 13, 2024 · 4 comments
Closed

Show total rows/avg row size in human readable format #16888

FrankChen021 opened this issue Aug 13, 2024 · 4 comments

Comments

@FrankChen021
Copy link
Member

The Data Source tab, we can render these two colums in human readable format as the 'Total data size' or 'Replicated size'

image

@kfaraz
Copy link
Contributor

kfaraz commented Aug 13, 2024

@FrankChen021 , the first column Total Rows denotes the total number of rows in the datasource, not the total size. Do you mean it should be displayed as 5 million, 63 billion, etc? I think the current approach of showing the exact total number of rows is better.

@FrankChen021
Copy link
Member Author

Yes, i mean show the number as 5M, 63B.

@vogievetsky
Copy link
Contributor

Those columns are human readable (that is what the ,s are for) the term you are looking for is "abbreviated".

There is a reason why I chose to show those column unabbreviated. Let me explain here and then if we can decide if it still applies.

The main issue with abbreviation is that it can make numbers that are very different visually appear very similar or even opposite in size. You can see it in the Total data size column in your screenshot. What is bigger 5.12 PB or 15.53 MB? what if you squint or take off your glasses (see blurry screenshot attached)? One way to solve this is to abbreviate the entire column to the same unit but that looses a lot of resolution on the small things.

The Total rows column is very special it can vary from 63 billion to 2 as it does in your screenshot. It is also common that people care about the exact number like if you are importing data from somewhere where you know you have 63,267,111,852 rows you want to see that 63,267,111,852 exactly made it into Druid. By leaving it unabbreviated it easily shows the relative size of the datasource even from afar (again see my blurred screenshot). Lastly it is just cool to see a big number.

The Avg row size is unabbreviated because it simply no likely to have a lot of range. Rows in Druid rarely exceed a couple of kilobytes in size. If your rows are getting close to megabytes you would very much want to know it very prominently.

image

@FrankChen021
Copy link
Member Author

I think you're right, sometimes users might care about the exact number of rows. it's complex if we support both formats.
let me close this proposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants