Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backpressure metrics #6321

Closed
gianm opened this issue Sep 10, 2018 · 2 comments
Closed

Backpressure metrics #6321

gianm opened this issue Sep 10, 2018 · 2 comments
Labels
Area - Querying Starter

Comments

@gianm
Copy link
Contributor

gianm commented Sep 10, 2018

See #6313, and in particular, #6313 (review). It would be nice to have a per-query-per-node metric similar to query/node/time and query/node/ttfb, which measures how much time the channel has spent in an unreadable state. Perhaps query/node/backpressure.
@gianm gianm mentioned this issue Sep 10, 2018
Merged
@gianm gianm added the Starter label Sep 10, 2018
@gianm
Copy link
Contributor Author

gianm commented Sep 10, 2018

Most of the changes here should be in DirectDruidClient. It will also involve some additions to QueryMetrics.

@shivtools shivtools mentioned this issue Sep 16, 2018
Merged
@gianm
Copy link
Contributor Author

gianm commented Oct 20, 2018

Fixed by #6335.

@gianm gianm closed this as completed Oct 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area - Querying Starter
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gianm