Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Published segments cache in Brokers shouldn't use Interners #7395

Open
leventov opened this issue Apr 1, 2019 · 4 comments
Open

Published segments cache in Brokers shouldn't use Interners #7395

leventov opened this issue Apr 1, 2019 · 4 comments
Labels
Area - Metadata Area - SQL Evergreen Stalebot will ignore this issue Performance

Comments

@leventov
Copy link
Member

leventov commented Apr 1, 2019

Regarding #6901 (proposal: #6834)

Published segments cache in Brokers shouldn't use Interners. Instead, MetadataSegmentView should probe into BrokerServerView's data and vice versa, similar to was is done in Coordinator's memory: #6357.

FYI @surekhasaharan
@leventov leventov mentioned this issue Apr 1, 2019
Merged
@gianm
Copy link
Contributor

gianm commented Apr 1, 2019

What's wrong with Interners? I don't see a discussion in #6357.

@leventov
Copy link
Member Author

leventov commented Apr 1, 2019 •
edited
Loading

The explanation is in the PR description. You are getting rid of one giant map with weak references which hogs the memory. Weak refs are also bad for GC.

@leventov leventov mentioned this issue Apr 18, 2019
Merged
@leventov leventov mentioned this issue May 27, 2019
Open
@stale
Copy link

stale bot commented Jun 20, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jun 20, 2019
@leventov leventov added the Evergreen Stalebot will ignore this issue label Jun 26, 2019
@stale
Copy link

stale bot commented Jun 26, 2019

This issue is no longer marked as stale.

@stale stale bot removed the stale label Jun 26, 2019
@leventov leventov mentioned this issue Jul 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area - Metadata Area - SQL Evergreen Stalebot will ignore this issue Performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@leventov @gianm