-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove "granularity" from IngestSegmentFirehose. #4110
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -79,7 +79,6 @@ public DatasourcePathSpecTest() | |
null, | ||
null, | ||
null, | ||
null, | ||
false | ||
); | ||
|
||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,7 +26,7 @@ | |
import io.druid.data.input.Firehose; | ||
import io.druid.data.input.InputRow; | ||
import io.druid.data.input.MapBasedInputRow; | ||
import io.druid.java.util.common.granularity.Granularity; | ||
import io.druid.java.util.common.granularity.Granularities; | ||
import io.druid.java.util.common.guava.Sequence; | ||
import io.druid.java.util.common.guava.Sequences; | ||
import io.druid.java.util.common.guava.Yielder; | ||
|
@@ -59,8 +59,7 @@ public IngestSegmentFirehose( | |
final List<WindowedStorageAdapter> adapters, | ||
final List<String> dims, | ||
final List<String> metrics, | ||
final DimFilter dimFilter, | ||
final Granularity granularity | ||
final DimFilter dimFilter | ||
) | ||
{ | ||
Sequence<InputRow> rows = Sequences.concat( | ||
|
@@ -77,7 +76,7 @@ public Sequence<InputRow> apply(WindowedStorageAdapter adapter) | |
Filters.toFilter(dimFilter), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Maybe could be further simplified by not calling There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. How else would this be turned into a There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ok, seems there is no way. |
||
adapter.getInterval(), | ||
VirtualColumns.EMPTY, | ||
granularity, | ||
Granularities.ALL, | ||
false | ||
), new Function<Cursor, Sequence<InputRow>>() | ||
{ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now this method is effectively just "clone", the method argument is unused.