Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

配置“group”信息无效,可能是dubbo-url的from方法有问题 #137

Closed
shige8023 opened this issue Sep 7, 2019 · 1 comment
Closed

Comments

@shige8023
Copy link

dubbosetting配置了“group”信息后调用失败,导致我一度以为是我配置写错了,深入探究了该项目源码后,发现dubbo-url的from方法这里,取的“group”是“group”,然后查了dubbo的服务注册信息,发现group信息的配置为“default.group”,将dubbo-url的from方法改为如下,可以正常使用
class DubboUrl { constructor(providerUrl) { log('DubboUrl from -> %s', providerUrl); this._url = url_1.default.parse(providerUrl); this._query = querystring_1.default.parse(providerUrl); this.host = this._url.hostname; this.port = Number(this._url.port); this.path = this._url.pathname.substring(1); this.dubboVersion = this._query.dubbo || ''; this.version = this._query.version || this._query['default.version'] || '0.0.0'; this.group = this._query.group || this._query['default.group']|| ''; } static from(providerUrl) { return new DubboUrl(providerUrl); } }

@hufeng
Copy link
Member

hufeng commented Nov 8, 2019

fixed #138

@hufeng hufeng closed this as completed Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants