Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't compile under JDK 1.9, caused by an invalid import. #1116

Closed
markyao opened this issue Dec 26, 2017 · 3 comments
Closed

Can't compile under JDK 1.9, caused by an invalid import. #1116

markyao opened this issue Dec 26, 2017 · 3 comments
Labels
type/bug Bugs to being fixed
Milestone
2.5.9

Comments

@markyao
Copy link

markyao commented Dec 26, 2017 •
edited

com.alibaba.dubbo.config.spring.context.annotation.provider里面
import com.sun.org.apache.regexp.internal.RE无效导入JDK9下部能编译通过
同时下面两个也是无效导入
import com.alibaba.dubbo.rpc.Protocol;
import org.springframework.context.annotation.ImportResource;
@markyao markyao changed the title 代码中无效导致JDK9下部能编译通过 代码中无效导致JDK9下不能编译通过 Dec 26, 2017
@markyao markyao changed the title 代码中无效导致JDK9下不能编译通过 代码中无效导入JDK9下不能编译通过 Dec 26, 2017
@mercyblitz mercyblitz self-assigned this Dec 26, 2017
@mercyblitz mercyblitz added the type/bug Bugs to being fixed label Dec 26, 2017
@mercyblitz mercyblitz added this to the 2.5.9 milestone Dec 26, 2017
@mercyblitz
Copy link
Contributor

It will be resolved in next release , please add fake class to compile

@mercyblitz
Copy link
Contributor

You also could remove some test cases , sorry for careless :(

mercyblitz added a commit to mercyblitz/dubbo that referenced this issue Dec 26, 2017
@mercyblitz
To resolve alibaba/dubbo apache#1116
5d25fc7
@chickenlj chickenlj changed the title 代码中无效导入JDK9下不能编译通过 Can't compile under JDK 1.9, caused by an invalid import. Dec 28, 2017
chickenlj pushed a commit that referenced this issue Jan 22, 2018
@mercyblitz @chickenlj
Merge pull request #1205, annotation enhancement and bugfixes
5d8acea 
* Fixed #1116 #1120 #1121 #1122 #1141 #1125 

* DubboConfigConfiguration's Single and Multiple to be public classes

* @DubboComponentScan is compatible with Spring @service completely

* @service and @reference issues on <dubbo:annotation>

* To fix an issue on <dubbo:annotation> when id attribute is absent

* To change the prefixes of properties when @EnableDubboConfig binds
multiple Config Bean
@chickenlj
Copy link
Contributor

It's been fixed

rolandhe pushed a commit to rolandhe/dubbo that referenced this issue Sep 9, 2019
@mercyblitz @chickenlj
Merge pull request apache#1205, annotation enhancement and bugfixes
c59adee 
* Fixed apache#1116 apache#1120 apache#1121 apache#1122 apache#1141 apache#1125 

* DubboConfigConfiguration's Single and Multiple to be public classes

* @DubboComponentScan is compatible with Spring @service completely

* @service and @reference issues on <dubbo:annotation>

* To fix an issue on <dubbo:annotation> when id attribute is absent

* To change the prefixes of properties when @EnableDubboConfig binds
multiple Config Bean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug Bugs to being fixed
Projects
None yet
Milestone
2.5.9
Development

No branches or pull requests
3 participants
@mercyblitz @markyao @chickenlj