Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@DubboComponentScan is not compatible Spring @Service completely #1120

Closed
mercyblitz opened this issue Dec 26, 2017 · 0 comments
Closed

@DubboComponentScan is not compatible Spring @Service completely #1120

mercyblitz opened this issue Dec 26, 2017 · 0 comments
Assignees
@mercyblitz
Labels
type/bug Bugs to being fixed
Milestone
2.5.9

Comments

@mercyblitz
Copy link
Contributor

mercyblitz commented Dec 26, 2017 •
edited

If Service bean annotated Dubbo @Service and Spring @Service and @ComponentScan executes earlier than @DubboComponentScan , current been will not be a candidate of @Service Bean.

@DubboComponentScan should consider this scenario:

There are two classes : A and B under packages com.acme :
A with Dubbo @Service
B with Spring @Service and Dubbo @Service

@ComponentScan scans this package first, and B will be a candidate of @Service Bean , and then @DubboComponentScan also scans same package , just A will be exported as Dubbo Remote interface , B will be missing.
@mercyblitz mercyblitz added the type/bug Bugs to being fixed label Dec 26, 2017
@mercyblitz mercyblitz added this to the 2.5.9 milestone Dec 26, 2017
@mercyblitz mercyblitz self-assigned this Dec 26, 2017
mercyblitz added a commit to mercyblitz/dubbo that referenced this issue Dec 26, 2017
@mercyblitz
@DubboComponentScan is compatible with Spring @service completely ,
827d5b6 
to fix alibaba/dubbo apache#1120
@mercyblitz mercyblitz mentioned this issue Jan 12, 2018
Merged
chickenlj pushed a commit that referenced this issue Jan 22, 2018
@mercyblitz @chickenlj
Merge pull request #1205, annotation enhancement and bugfixes
5d8acea 
* Fixed #1116 #1120 #1121 #1122 #1141 #1125 

* DubboConfigConfiguration's Single and Multiple to be public classes

* @DubboComponentScan is compatible with Spring @service completely

* @service and @reference issues on <dubbo:annotation>

* To fix an issue on <dubbo:annotation> when id attribute is absent

* To change the prefixes of properties when @EnableDubboConfig binds
multiple Config Bean
rolandhe pushed a commit to rolandhe/dubbo that referenced this issue Sep 9, 2019
@mercyblitz @chickenlj
Merge pull request apache#1205, annotation enhancement and bugfixes
c59adee 
* Fixed apache#1116 apache#1120 apache#1121 apache#1122 apache#1141 apache#1125 

* DubboConfigConfiguration's Single and Multiple to be public classes

* @DubboComponentScan is compatible with Spring @service completely

* @service and @reference issues on <dubbo:annotation>

* To fix an issue on <dubbo:annotation> when id attribute is absent

* To change the prefixes of properties when @EnableDubboConfig binds
multiple Config Bean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mercyblitz mercyblitz

Labels
type/bug Bugs to being fixed
Projects
None yet
Milestone
2.5.9
Development

No branches or pull requests
1 participant
@mercyblitz