Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change the prefixes of properties when @EnableDubboConfig binds multiple Config Bean #1141

Closed
mercyblitz opened this issue Dec 28, 2017 · 0 comments
Closed

change the prefixes of properties when @EnableDubboConfig binds multiple Config Bean #1141

mercyblitz opened this issue Dec 28, 2017 · 0 comments
Assignees
@mercyblitz
Milestone
2.5.9

Comments

@mercyblitz
Copy link
Contributor

Since Dubbo 2.5.8 , @EnableDubboConfig supports binds multiple Config Bean when its' multiple() equals true , however, the prefixes of properties as below ：

  • dubbo.application
  • dubbo.module
  • dubbo.registry
  • dubbo.protocol
  • dubbo.monitor
  • dubbo.provider
  • dubbo.consumer

According to English convention , those prefixes should be plural noun ， thus they are required to be changed :

  • dubbo.applications
  • dubbo.modules
  • dubbo.registries
  • dubbo.protocols
  • dubbo.monitors
  • dubbo.providers
  • dubbo.consumers
@mercyblitz mercyblitz added this to the 2.5.9 milestone Dec 28, 2017
@mercyblitz mercyblitz self-assigned this Dec 28, 2017
mercyblitz added a commit to mercyblitz/dubbo that referenced this issue Dec 28, 2017
@mercyblitz
To change the prefixes of properties when @EnableDubboConfig binds
b386a3f 
multiple Config Bean
To resolve alibaba/dubbo apache#1141
@mercyblitz mercyblitz mentioned this issue Jan 12, 2018
Merged
chickenlj pushed a commit that referenced this issue Jan 22, 2018
@mercyblitz @chickenlj
Merge pull request #1205, annotation enhancement and bugfixes
5d8acea 
* Fixed #1116 #1120 #1121 #1122 #1141 #1125 

* DubboConfigConfiguration's Single and Multiple to be public classes

* @DubboComponentScan is compatible with Spring @service completely

* @service and @reference issues on <dubbo:annotation>

* To fix an issue on <dubbo:annotation> when id attribute is absent

* To change the prefixes of properties when @EnableDubboConfig binds
multiple Config Bean
@morisenmen morisenmen mentioned this issue Feb 25, 2019
Closed
rolandhe pushed a commit to rolandhe/dubbo that referenced this issue Sep 9, 2019
@mercyblitz @chickenlj
Merge pull request apache#1205, annotation enhancement and bugfixes
c59adee 
* Fixed apache#1116 apache#1120 apache#1121 apache#1122 apache#1141 apache#1125 

* DubboConfigConfiguration's Single and Multiple to be public classes

* @DubboComponentScan is compatible with Spring @service completely

* @service and @reference issues on <dubbo:annotation>

* To fix an issue on <dubbo:annotation> when id attribute is absent

* To change the prefixes of properties when @EnableDubboConfig binds
multiple Config Bean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mercyblitz mercyblitz

Labels
None yet
Projects
None yet
Milestone
2.5.9
Development

No branches or pull requests
1 participant
@mercyblitz