Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JRE utils (#11393) #11396

Merged
merged 4 commits into from
Jan 30, 2023
Merged

Add JRE utils (#11393) #11396

merged 4 commits into from
Jan 30, 2023

Conversation

KamToHung
Copy link
Contributor

What is the purpose of the change

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

Codecov Report

Merging #11396 (69d29f6) into 3.2 (b456d23) will decrease coverage by 4.78%.
The diff coverage is 48.83%.

@@             Coverage Diff              @@
##                3.2   #11396      +/-   ##
============================================
- Coverage     69.57%   64.79%   -4.78%     
+ Complexity      119       14     -105     
============================================
  Files          1525     1498      -27     
  Lines         82580    62538   -20042     
  Branches      14719     9149    -5570     
============================================
- Hits          57453    40520   -16933     
+ Misses        20273    17776    -2497     
+ Partials       4854     4242     -612     
Impacted Files Coverage Δ
...che/dubbo/common/utils/ConcurrentHashMapUtils.java 14.28% <0.00%> (-52.39%) ⬇️
...c/main/java/org/apache/dubbo/common/utils/JRE.java 50.00% <50.00%> (ø)
...luster/router/script/ScriptStateRouterFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...he/dubbo/test/common/impl/GreetingServiceImpl.java 0.00% <0.00%> (-100.00%) ⬇️
...zookeeper/curator/CuratorZookeeperTransporter.java 0.00% <0.00%> (-100.00%) ⬇️
.../serialize/hessian2/Hessian2SerializerFactory.java 0.00% <0.00%> (-100.00%) ⬇️
...nfigure/DubboRelaxedBinding2AutoConfiguration.java 0.00% <0.00%> (-100.00%) ⬇️
.../apache/dubbo/test/spring/SpringXmlConfigTest.java 0.00% <0.00%> (-96.16%) ⬇️
...egistrycenter/context/ZookeeperWindowsContext.java 0.00% <0.00%> (-81.82%) ⬇️
...istrycenter/processor/FindPidWindowsProcessor.java 5.40% <0.00%> (-81.09%) ⬇️
... and 479 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Jan 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

49.2% 49.2% Coverage
0.0% 0.0% Duplication

@AlbumenJ AlbumenJ merged commit e933f57 into apache:3.2 Jan 30, 2023
@KamToHung KamToHung deleted the jre_version branch January 30, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants