Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect timeout message #13001

Merged
merged 2 commits into from Sep 12, 2023
Merged

Conversation

tianshuang
Copy link
Contributor

@tianshuang tianshuang commented Sep 3, 2023

What is the purpose of the change

As the title says, fix incorrect timeout message. The time it takes for the client to send messages may exceed the set timeout. In this case, the timeout information should prompt "client-side timeout" instead of "server-side timeout".

Brief changelog

  • Modified org.apache.dubbo.remoting.exchange.support.DefaultFuture#getTimeoutMessage
  • Add org.apache.dubbo.remoting.exchange.support.DefaultFutureTest#clientTimeoutSend

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

Codecov Report

Merging #13001 (0c5c5e2) into 3.2 (e436f1e) will decrease coverage by 0.40%.
Report is 1 commits behind head on 3.2.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                3.2   #13001      +/-   ##
============================================
- Coverage     69.78%   69.39%   -0.40%     
+ Complexity      341        2     -339     
============================================
  Files          3527     1650    -1877     
  Lines        167828    68522   -99306     
  Branches      28073    10000   -18073     
============================================
- Hits         117126    47553   -69573     
+ Misses        40574    16378   -24196     
+ Partials      10128     4591    -5537     

see 1901 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Sep 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@tianshuang
Copy link
Contributor Author

@disabled annotation has been removed, @AlbumenJ

@AlbumenJ AlbumenJ merged commit 52250b8 into apache:3.2 Sep 12, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants