Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong comment with DubboBootstrap.useRegistryAsConfigCenterIfNecessary #5841

Merged
merged 2 commits into from
Apr 1, 2020

Conversation

laddcn
Copy link
Contributor

@laddcn laddcn commented Mar 8, 2020

What is the purpose of the change

Fix wrong comment with DubboBootstrap.useRegistryAsConfigCenterIfNecessary

Brief changelog

Original comment mentioned "For compatibility purpose, use registry as the default config center when the registry protocol is zookeeper and there's no config center specified explicitly.".
However, it seems this method works ignore the registry protocol because it use registry as the default config when I use nacos as registry protocol.
I debugged this method and found out this method will use registry as the default config when there's no config center specified explicitly and useAsConfigCenter of registryConfig is null or true. So I modified this comment.

Verifying this change

All test cases work fine.

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a GITHUB_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [Dubbo-XXX] Fix UnknownException when host config not exist #XXX. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Run mvn clean install -DskipTests=false & mvn clean test-compile failsafe:integration-test to make sure unit-test and integration-test pass.
  • If this contribution is large, please follow the Software Donation Guide.

@chickenlj chickenlj merged commit 3ce6228 into apache:master Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants