Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] Add serializingExecutor #8999

Merged
merged 6 commits into from Oct 9, 2021
Merged

[3.0] Add serializingExecutor #8999

merged 6 commits into from Oct 9, 2021

Conversation

EarthChen
Copy link
Member

@EarthChen EarthChen commented Oct 9, 2021

What is the purpose of the change

  • wrapper executor for the task execute serially
  • wrapper stream executor

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Oct 9, 2021

Codecov Report

Merging #8999 (37d8e1b) into 3.0 (bb273ff) will increase coverage by 0.00%.
The diff coverage is 52.11%.

Impacted file tree graph

@@            Coverage Diff            @@
##                3.0    #8999   +/-   ##
=========================================
  Coverage     63.36%   63.37%           
+ Complexity      315      314    -1     
=========================================
  Files          1185     1186    +1     
  Lines         50325    50357   +32     
  Branches       7525     7525           
=========================================
+ Hits          31889    31912   +23     
- Misses        14955    14963    +8     
- Partials       3481     3482    +1     
Impacted Files Coverage Δ
...rg/apache/dubbo/rpc/protocol/tri/ServerStream.java 44.11% <12.00%> (-1.05%) ⬇️
...e/dubbo/rpc/protocol/tri/AbstractServerStream.java 51.54% <60.00%> (-0.89%) ⬇️
.../apache/dubbo/rpc/protocol/tri/AbstractStream.java 42.77% <71.42%> (-1.02%) ⬇️
.../common/threadpool/serial/SerializingExecutor.java 77.77% <77.77%> (ø)
.../remoting/transport/netty4/NettyServerHandler.java 58.13% <0.00%> (-9.31%) ⬇️
...he/dubbo/remoting/transport/netty/NettyServer.java 70.17% <0.00%> (-3.51%) ⬇️
...pache/dubbo/remoting/transport/AbstractClient.java 60.71% <0.00%> (-1.43%) ⬇️
...bo/registry/support/CacheableFailbackRegistry.java 77.10% <0.00%> (-1.21%) ⬇️
...java/org/apache/dubbo/remoting/api/Connection.java 72.03% <0.00%> (-0.85%) ⬇️
...ng/zookeeper/curator5/Curator5ZookeeperClient.java 67.96% <0.00%> (-0.49%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb273ff...37d8e1b. Read the comment docs.

Copy link
Contributor

@guohao guohao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@guohao guohao merged commit f561138 into apache:3.0 Oct 9, 2021
@EarthChen EarthChen mentioned this pull request Oct 9, 2021
8 tasks
@EarthChen EarthChen deleted the feature/SerializingExecutor branch October 9, 2021 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants