Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.0] Add KeyAffinityExecutor #8975

Closed
wants to merge 5 commits into from
Closed

[3.0] Add KeyAffinityExecutor #8975

wants to merge 5 commits into from

Conversation

EarthChen
Copy link
Member

What is the purpose of the change

  • add KeyAffinityExecutor for stream scenario (Because a stream can contain multiple user methods, they need to run sequentially in one thread)

Brief changelog

Verifying this change

Checklist

  • Make sure there is a GitHub_issue field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in dubbo samples project.
  • Add some description to dubbo-website project if you are requesting to add a feature.
  • GitHub Actions works fine on your own branch.
  • If this contribution is large, please follow the Software Donation Guide.

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2021

Codecov Report

Merging #8975 (f6b8a50) into 3.0 (403a989) will decrease coverage by 0.38%.
The diff coverage is 72.56%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.0    #8975      +/-   ##
============================================
- Coverage     63.71%   63.32%   -0.39%     
+ Complexity      315      312       -3     
============================================
  Files          1183     1191       +8     
  Lines         50270    50407     +137     
  Branches       7525     7536      +11     
============================================
- Hits          32029    31920     -109     
- Misses        14747    14988     +241     
- Partials       3494     3499       +5     
Impacted Files Coverage Δ
...readpool/affinity/AbstractKeyAffinityExecutor.java 55.81% <55.81%> (ø)
...mmon/threadpool/affinity/MinActiveKeyAffinity.java 63.63% <63.63%> (ø)
...ommon/threadpool/affinity/AbstractKeyAffinity.java 83.33% <83.33%> (ø)
.../dubbo/common/threadpool/affinity/KeyAffinity.java 100.00% <100.00%> (ø)
...eadpool/affinity/MinActiveKeyAffinityExecutor.java 100.00% <100.00%> (ø)
.../common/threadpool/affinity/RandomKeyAffinity.java 100.00% <100.00%> (ø)
...threadpool/affinity/RandomKeyAffinityExecutor.java 100.00% <100.00%> (ø)
.../threadpool/manager/DefaultExecutorRepository.java 67.39% <100.00%> (ø)
...figcenter/file/FileSystemDynamicConfiguration.java 0.00% <0.00%> (-57.21%) ⬇️
...fig/configcenter/TreePathDynamicConfiguration.java 60.00% <0.00%> (-25.72%) ⬇️
... and 38 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 403a989...f6b8a50. Read the comment docs.

@AlbumenJ AlbumenJ requested a review from guohao October 9, 2021 07:56
@EarthChen EarthChen closed this Oct 9, 2021
@EarthChen
Copy link
Member Author

use #8999 replace this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants