New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix - ExtensionLoader can not inject by type properly. #9187
Bugfix - ExtensionLoader can not inject by type properly. #9187
Conversation
refactor DisableInject Annotation to the generic Inject Annotation.
Codecov Report
@@ Coverage Diff @@
## master #9187 +/- ##
============================================
+ Coverage 60.51% 60.86% +0.35%
- Complexity 413 446 +33
============================================
Files 1100 1101 +1
Lines 44523 44535 +12
Branches 6479 6482 +3
============================================
+ Hits 26943 27107 +164
+ Misses 14619 14453 -166
- Partials 2961 2975 +14
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
refactor DisableInject Annotation to the generic Inject Annotation.
dubbo-common/src/main/java/org/apache/dubbo/common/extension/Inject.java
Show resolved
Hide resolved
dubbo-common/src/main/java/org/apache/dubbo/common/extension/ExtensionLoader.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review
Fix #9150
Fix ExtensionLoader can not inject by type properly
What is the purpose of the change
Let ExtensionLoader support inject by type.
Brief changelog
Verifying this change
ExtensionLoader can inject by type, for instance, custom filter has setter method and inject
dependencies by type via annotation it with @Inject(type = ByType).
Checklist