Fix: (1) number getPrecisionSafe incorrect on scientific notation like 3.45e-1 (2) stack sum eliminate floating arithmetic problem. (3) Should no dataZoom filtering when toolbox.feature.dataZoom not declared.
#15015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! The pull request is marked to be |
100pah
changed the title
pissang
reviewed
May 24, 2021
src/util/number.ts
Outdated
| * See <http://0.30000000000000004.com/> | ||
| */ | ||
| export function addSafe(val0: number, val1: number): number { | ||
| const maxPrecision = Math.max(getPrecisionSafe(val0), getPrecisionSafe(val1)); |
There was a problem hiding this comment.
Can we use ROUND_SUPPORTED_PRECISION_MAX in the
Line 164 in a46d2e6
to avoid infinity loop? That method is much faster.
…Zoom filter performed.
100pah
changed the title
toolbox.feature.dataZoom not declared.
pissang
approved these changes
May 31, 2021
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1) number getPrecisionSafe incorrect on scientific notation like 3.45e-1
(2) stack sum eliminate floating arithmetic problem.
Brief Information
This pull request is in the type of:
What does this PR do?
fix:
getPrecisionSafeincorrect on scientific notation like 3.45e-1getPrecisionand usegetPrecisioninstead ofgetPrecisionSafe.toolboxdeclared buttoolbox.feature.dataZoomnot declared, should no dataZoom filter performed.Fix #14668
Test cases
<test/axis-filter-extent2.html>
<test/ut/spec/util/number.ts>