fix(type): there is no function 'clampData' error in 'getMarkerPosition' #15297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
AmosChenYQ
changed the title
|
For further improvements. We need to implement |
pissang
approved these changes
Jul 7, 2021
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix no function 'clampData' error in 'getMarkerPosition' method of BaseBarSeriesModel
Brief Information
This pull request is in the type of:
What does this PR do?
fix no function 'clampData' error in 'getMarkerPosition' method of BaseBarSeriesModel
Fixed issues
Issues 15109
Details
Before: What was the problem?
In that example will generate an error message of 'clampData is not a function'
After: How is it fixed in this PR?
Add an additonal judgement on 'clampData'
Misc
Related test cases or examples to use the new APIs
NA.
Others
Merging options
Other information