Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(radar): lineStyle.join default round #13201 #15381

Merged
merged 1 commit into from
Jul 20, 2021
Merged

fix(radar): lineStyle.join default round #13201 #15381

merged 1 commit into from
Jul 20, 2021

Conversation

Ovilia
Copy link
Contributor

@Ovilia Ovilia commented Jul 20, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Set lineStyle.join of radar series to be 'round' by default to solve the unexpected joint problem.

image

Fixed issues

Details

Before: What was the problem?

Unexpected angle outside of the radar area at the joint position.

After: How is it fixed in this PR?

Nothing outside the radar area.

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

NA.

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Jul 20, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the PR: awaiting doc label.

@echarts-bot echarts-bot bot added PR: author is committer PR: awaiting doc Document changes is required for this PR. PR: awaiting review labels Jul 20, 2021
@pissang pissang added this to the 5.2 milestone Jul 20, 2021
@pissang pissang merged commit 19834cf into master Jul 20, 2021
@echarts-bot
Copy link

echarts-bot bot commented Jul 20, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@pissang pissang deleted the fix-radar branch July 20, 2021 03:46
Ovilia added a commit to apache/echarts-doc that referenced this pull request Sep 1, 2021
@Ovilia Ovilia removed the PR: awaiting doc Document changes is required for this PR. label Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants