Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(line): mouse event on polyline and polygon #15847

Merged
merged 7 commits into from
Oct 19, 2021
Merged

Feat(line): mouse event on polyline and polygon #15847

merged 7 commits into from
Oct 19, 2021

Conversation

susiwen8
Copy link
Contributor

@susiwen8 susiwen8 commented Oct 9, 2021 •
edited by plainheart
Loading

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Add click and mouseover for polyline and polygon

Fixed issues

Close #13637
Close #13843
close #15834

revert #15535

Details

Before: What was the problem?

After: How is it fixed in this PR?

Kapture 2021-10-09 at 23 10 17

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

polyline-gon-event.html

Others

Merging options

  • Please squash the commits into a single one when merge.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Oct 9, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@susiwen8 susiwen8 requested a review from pissang October 9, 2021 15:11
pissang
pissang requested changes Oct 11, 2021
View reviewed changes
src/chart/line/LineView.ts Outdated Show resolved Hide resolved
@susiwen8 susiwen8 requested a review from pissang October 15, 2021 13:15
pissang
pissang requested changes Oct 17, 2021
View reviewed changes
src/chart/line/LineView.ts Outdated Show resolved Hide resolved
src/chart/line/LineView.ts Outdated Show resolved Hide resolved
src/chart/line/LineView.ts Outdated Show resolved Hide resolved
@pissang
Copy link
Contributor

pissang commented Oct 17, 2021

I think we need an option to enable this event. It may break the apps that don't check if dataIndex exists in their event handler.

@susiwen8 susiwen8 requested a review from pissang October 17, 2021 02:46
@susiwen8
Copy link
Contributor Author

I think we need an option to enable this event. It may break the apps that don't check if dataIndex exists in their event handler.

Add enableLineEvent option

@pissang pissang added this to the 5.3 milestone Oct 17, 2021
plainheart
plainheart reviewed Oct 17, 2021
View reviewed changes
Copy link
Member

@plainheart plainheart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI

src/chart/line/LineSeries.ts Outdated Show resolved Hide resolved
src/chart/line/LineView.ts Outdated Show resolved Hide resolved
@pissang pissang changed the base branch from master to next October 18, 2021 02:03
@pull-request-size pull-request-size bot added size/L and removed size/M labels Oct 18, 2021
pissang
pissang reviewed Oct 18, 2021
View reviewed changes
src/chart/line/LineView.ts Outdated Show resolved Hide resolved
@pissang pissang modified the milestones: 5.3, 5.2.2 Oct 18, 2021
@pissang pissang changed the base branch from next to master October 18, 2021 05:17
@pull-request-size pull-request-size bot added size/M and removed size/L labels Oct 18, 2021
@echarts-bot echarts-bot bot added the PR: awaiting doc Document changes is required for this PR. label Oct 19, 2021
@pissang pissang merged commit f73e6e0 into apache:master Oct 19, 2021
@echarts-bot
Copy link

echarts-bot bot commented Oct 19, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@susiwen8 susiwen8 deleted the line-event branch October 19, 2021 05:16
@susiwen8 susiwen8 mentioned this pull request Oct 20, 2021
Merged
@plainheart plainheart removed the PR: awaiting doc Document changes is required for this PR. label Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plainheart plainheart plainheart approved these changes

@pissang pissang pissang approved these changes

Assignees
No one assigned
Labels
PR: author is committer size/M
Projects
None yet
Milestone
5.2.2
3 participants
@susiwen8 @pissang @plainheart