Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bar): avoid creating subpaths in the sausage shape #16246

Merged
merged 1 commit into from
Dec 20, 2021

Conversation

pissang
Copy link
Contributor

@pissang pissang commented Dec 20, 2021

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

This PR optimize the sausage shape by avoiding creating subpaths with moveTo command. It can improve the visual effect of morphing significantly.

Details

Before: What was the problem?

Vertices are not matched when doing one-one morphing.

before

After: How is it fixed in this PR?

Vertices are matched perfectly.

morph

Misc

  • The API has been changed (apache/echarts-doc#xxx).
  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

N.A.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Dec 20, 2021

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@pissang pissang merged commit a818387 into master Dec 20, 2021
@echarts-bot
Copy link

echarts-bot bot commented Dec 20, 2021

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@pissang pissang deleted the fix-sausage-shape branch December 20, 2021 06:16
@pissang pissang added this to the 5.3 milestone Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants