Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pie): fix percent isn't updated after the legend is changed #17734

Merged
merged 3 commits into from
Oct 8, 2022

Conversation

plainheart
Copy link
Member

@plainheart plainheart commented Oct 8, 2022

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fix bugs brought in #17275.

  • The percent has wrong values after the legend is changed
  • The percent gets undefined value when all data are 0.

Fixed issues

Comparison

- Case A Case B
Before image image
After image image

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

Please refer to test/pie-percent.html

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Oct 8, 2022

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@plainheart plainheart added this to the 5.4.1 milestone Oct 8, 2022
@plainheart plainheart merged commit a840d46 into master Oct 8, 2022
@echarts-bot
Copy link

echarts-bot bot commented Oct 8, 2022

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

@plainheart plainheart deleted the fix/pie-percent branch October 8, 2022 10:59
@plainheart plainheart linked an issue Oct 8, 2022 that may be closed by this pull request
@plainheart plainheart linked an issue Oct 10, 2022 that may be closed by this pull request
@plainheart plainheart linked an issue Oct 10, 2022 that may be closed by this pull request
@plainheart plainheart linked an issue Oct 28, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants