Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sunburst): radial rotation label might upside down #18240

Merged
merged 3 commits into from
Feb 24, 2023

Conversation

susiwen8
Copy link
Contributor

@susiwen8 susiwen8 commented Feb 4, 2023

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

sunbrust label might upside down under radial rotation

Fixed issues

Details

Before: What was the problem?

Screenshot 2023-02-04 at 15 31 48

After: How does it behave after the fixing?

Screenshot 2023-02-04 at 15 31 36

Document Info

One of the following should be checked.

Misc

ZRender Changes

  • This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

sunburst-label.html

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

@echarts-bot
Copy link

echarts-bot bot commented Feb 4, 2023

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

Copy link
Contributor

@Ovilia Ovilia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot why startAngle is not provided in the document, whether it's a bug or intentionally. Anyway, if this issue is to be accepted, we should also update the document.
I think it should be a good idea to use dat.gui to dynamically change the startAngle to check it works well with all situations. We also may need to restrict the range of valid startAngle in the document.

@echarts-bot
Copy link

echarts-bot bot commented Feb 16, 2023

⚠️ MISSING DOCUMENT INFO: Please make sure one of the document options are checked in this PR's description. Search "Document Info" in the description of this PR. This should be done either by the author or the reviewers of the PR.

@echarts-bot echarts-bot bot added PR: awaiting doc Document changes is required for this PR. and removed PR: doc unchanged labels Feb 16, 2023
@echarts-bot
Copy link

echarts-bot bot commented Feb 16, 2023

Document changes are required in this PR. Please also make a PR to apache/echarts-doc for document changes and update the issue id in the PR description. When the doc PR is merged, the maintainers will remove the PR: awaiting doc label.

@susiwen8
Copy link
Contributor Author

I forgot why startAngle is not provided in the document, whether it's a bug or intentionally. Anyway, if this issue is to be accepted, we should also update the document. I think it should be a good idea to use dat.gui to dynamically change the startAngle to check it works well with all situations. We also may need to restrict the range of valid startAngle in the document.

Ok, I will update it

@susiwen8
Copy link
Contributor Author

@Ovilia Test case has updated, thanks to your suggestion about dat.gui, more strange case was exposed.
Also document for startAngle was added.

@echarts-bot echarts-bot bot added PR: doc ready and removed PR: awaiting doc Document changes is required for this PR. labels Feb 20, 2023
@Ovilia
Copy link
Contributor

Ovilia commented Feb 21, 2023

LGTM but not sure why the lint CI failed. @susiwen8 Can you have a double-check?

@susiwen8
Copy link
Contributor Author

susiwen8 commented Feb 21, 2023

Looks like github.sha return the wrong commit id <img width="1110" alt="Screenshot 2023-02-21 at 22 25 31" src="https://user-images.githubusercontent.com/20318608/220371687-d050c065-5d8d-4021-afbf-7821dab7c168.png"> I think we should follow this [suggestion](https://github.com/orgs/community/discussions/25191), relpace `github.sha` to `pull_request.head.sha` in `ci.yml
@Ovilia Ignore this

@susiwen8
Copy link
Contributor Author

@Ovilia Ci has passed

test/sunburst-label.html Show resolved Hide resolved
src/chart/sunburst/SunburstPiece.ts Outdated Show resolved Hide resolved
Copy link
Member

@plainheart plainheart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@susiwen8
Copy link
Contributor Author

@Ovilia Please take a look

@Ovilia
Copy link
Contributor

Ovilia commented Feb 24, 2023

A little unexpected thing is that when the rotation of a text is changed by 360° (e.g., from 1 to 359), it has an animation of rotating the text. But I think we can ignore this for now and see if it's necessary to be fixed if some developers bring this up.

@Ovilia Ovilia merged commit dbec96f into apache:master Feb 24, 2023
@echarts-bot
Copy link

echarts-bot bot commented Feb 24, 2023

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [Sunburst] Uses of startAngle provoke labels display bug
3 participants