Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip dom append to body, use to top of layer #8049

Merged
merged 3 commits into from
Jan 9, 2020
Merged

Tooltip dom append to body, use to top of layer #8049

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d9a446c
Tooltip dom append to body, use to top of layer
xinpureZhu Mar 28, 2018
440781b
dispose tooltip dom when component or chart disposed
xinpureZhu Mar 29, 2018
a51cc66
Merge branch 'master' into master
100pah Jan 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/component/tooltip/TooltipContent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ function TooltipContent(container, api) {
this._x = api.getWidth() / 2;
this._y = api.getHeight() / 2;

container.appendChild(el);
document.body.appendChild(el);

this._container = container;

Expand Down Expand Up @@ -292,6 +292,11 @@ TooltipContent.prototype = {
return this._show;
},


dispose: function () {
this.el.parentNode.removeChild(this.el)
},

getOuterSize: function () {
var width = this.el.clientWidth;
var height = this.el.clientHeight;
Expand All @@ -308,6 +313,7 @@ TooltipContent.prototype = {

return {width: width, height: height};
}

};

export default TooltipContent;
30 changes: 18 additions & 12 deletions src/component/tooltip/TooltipView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,10 @@ export default echarts.extendComponentView({
}

this._tooltipContent = tooltipContent;

this._event = {};
this._viewWidth = document.body.clientWidth;
this._viewHeight = document.body.clientHeight;
},

render: function (tooltipModel, ecModel, api) {
Expand Down Expand Up @@ -126,6 +130,7 @@ export default echarts.extendComponentView({
// If 'none', it is not controlled by mouse totally.
if (triggerOn !== 'none') {
if (triggerOn.indexOf(currTrigger) >= 0) {
this._event = e.event;
this._tryShow(e, dispatchAction);
}
else if (currTrigger === 'leave') {
Expand Down Expand Up @@ -201,15 +206,16 @@ export default echarts.extendComponentView({
this._tryShow({
offsetX: payload.x,
offsetY: payload.y,
target: el
target: el,
event: this._event
}, dispatchAction);
}
else if (dataByCoordSys) {
this._tryShow({
offsetX: payload.x,
offsetY: payload.y,
position: payload.position,
event: {},
event: this._event,
dataByCoordSys: payload.dataByCoordSys,
tooltipOption: payload.tooltipOption
}, dispatchAction);
Expand All @@ -229,7 +235,7 @@ export default echarts.extendComponentView({
offsetY: cy,
position: payload.position,
target: pointInfo.el,
event: {}
event: this._event
}, dispatchAction);
}
}
Expand All @@ -247,7 +253,7 @@ export default echarts.extendComponentView({
offsetY: payload.y,
position: payload.position,
target: api.getZr().findHover(payload.x, payload.y).target,
event: {}
event: this._event
}, dispatchAction);
}
},
Expand Down Expand Up @@ -314,8 +320,8 @@ export default echarts.extendComponentView({
}

// Save mouse x, mouse y. So we can try to keep showing the tip if chart is refreshed
this._lastX = e.offsetX;
this._lastY = e.offsetY;
this._lastX = e.event.pageX;
this._lastY = e.event.pageY;

var dataByCoordSys = e.dataByCoordSys;
if (dataByCoordSys && dataByCoordSys.length) {
Expand Down Expand Up @@ -353,7 +359,7 @@ export default echarts.extendComponentView({
_showAxisTooltip: function (dataByCoordSys, e) {
var ecModel = this._ecModel;
var globalTooltipModel = this._tooltipModel;
var point = [e.offsetX, e.offsetY];
var point = [e.event.pageX, e.event.pageY];
var singleDefaultHTML = [];
var singleParamsList = [];
var singleTooltipModel = buildTooltipModel([
Expand Down Expand Up @@ -509,7 +515,7 @@ export default echarts.extendComponentView({
this._showOrMove(tooltipModel, function () {
this._showTooltipContent(
tooltipModel, defaultHtml, params, asyncTicket,
e.offsetX, e.offsetY, e.position, e.target, markers
e.event.pageX, e.event.pageY, e.position, e.target, markers
);
});

Expand Down Expand Up @@ -545,7 +551,7 @@ export default echarts.extendComponentView({
this._showOrMove(subTooltipModel, function () {
this._showTooltipContent(
subTooltipModel, defaultHtml, subTooltipModel.get('formatterParams') || {},
asyncTicket, e.offsetX, e.offsetY, e.position, el
asyncTicket, e.event.pageX, e.event.pageY, e.position, el
);
});

Expand Down Expand Up @@ -607,8 +613,8 @@ export default echarts.extendComponentView({
* @return {Array.<number>}
*/
_updatePosition: function (tooltipModel, positionExpr, x, y, content, params, el) {
var viewWidth = this._api.getWidth();
var viewHeight = this._api.getHeight();
var viewWidth = this._viewWidth;
var viewHeight = this._viewHeight;
positionExpr = positionExpr || tooltipModel.get('position');

var contentSize = content.getSize();
Expand Down Expand Up @@ -727,7 +733,7 @@ export default echarts.extendComponentView({
if (env.node) {
return;
}
this._tooltipContent.hide();
this._tooltipContent.dispose();
globalListener.unregister('itemTooltip', api);
}
});
Expand Down