Update dependency org.threeten:threetenbp to v1.4.5- autoclosed

[renovate-bot]

This PR contains the following updates:

Package	Update	Change
org.threeten:threetenbp (source)	patch	1.4.1 -> 1.4.5

---

Release Notes

ThreeTen/threetenbp

v1.4.5

See the change notes for more information.

v1.4.4

See the change notes for more information.

v1.4.3

See the change notes for more information.

v1.4.2

See the change notes for more information.

---

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

---

• If you want to rebase/retry this PR, check this box

---

This PR has been generated by WhiteSource Renovate. View repository job log here.

[vorburger]

Hm, but why on earth would Fineract, now on Java 11, even require depending on a library which "backports JSR-310 to Java 6 & 7"? Let's not merge this, and see how hard it would be to just remove this dependency.. either literally "just" remove it, or changing any related import statements. Either way, should (hopefully) be fairly trivial? Does anyone want to try?

[vidakovic]

I quickly tried this quickly in #1416. I think we can remove that dependency; no complaints with integration tests. FYI

[ptuomola]

If you look in https://github.com/OpenAPITools/openapi-generator/blob/master/docs/generators/java.md, it seems this library is not needed, given we are setting dateLibrary as java8 In general the list of dependencies for the client seems very extensive - do we really need all of these...

…

On Sat, 17 Oct 2020, 9:20 pm Aleksandar Vidakovic, ***@***.***> wrote: I quickly tried this quickly in #1416 <#1416>. I think we can remove that dependency; no complaints with integration tests. FYI — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#1415 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AASJVCUJDD4ULWYGMDGQY3TSLHOATANCNFSM4SUPDILA> .

[vidakovic]

@ptuomola threeten can go... the others can be reduced for the kind of client we are currently generating. 

In general I would suggest switching to BOMs, which saves us some time in the dependency management section (otherwise we have 2 places where we need to edit).

[vorburger]

Ergo, No Go on merging this as is. But let's keep it open, as a reminder, until we've removed threeten.