[FLINK-35092][cdc][starrocks] Add starrocks integration test cases #3231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @banmoy |
yuxiqian
force-pushed
the
FLINK-35092
branch
2 times, most recently
from
077b669
to
d1b3062
Compare
banmoy
reviewed
Apr 22, 2024
...-connectors/flink-cdc-pipeline-connector-starrocks/src/test/resources/log4j2-test.properties
Outdated
Show resolved
Hide resolved
...s/src/test/java/org/apache/flink/cdc/connectors/starrocks/sink/utils/StarRocksContainer.java
Outdated
Show resolved
Hide resolved
|
|
||
| // FE node exposed ports | ||
| public static final int FE_HTTP_PORT = 8030; | ||
| public static final int FE_HTTP_SERVICE_PORT = 8080; |
There was a problem hiding this comment.
StarRocks all-in-one docker image exposes 8080 as service port in this PR. Removed redundant port mappings.
...rc/test/java/org/apache/flink/cdc/connectors/starrocks/sink/utils/StarRocksSinkTestBase.java
Show resolved
Hide resolved
...rc/test/java/org/apache/flink/cdc/connectors/starrocks/sink/utils/StarRocksSinkTestBase.java
Outdated
Show resolved
Hide resolved
...ks/src/test/java/org/apache/flink/cdc/connectors/starrocks/sink/StarRocksPipelineITCase.java
Outdated
Show resolved
Hide resolved
...ks/src/test/java/org/apache/flink/cdc/connectors/starrocks/sink/StarRocksPipelineITCase.java
Outdated
Show resolved
Hide resolved
...ks/src/test/java/org/apache/flink/cdc/connectors/starrocks/sink/StarRocksPipelineITCase.java
Outdated
Show resolved
Hide resolved
...ks/src/test/java/org/apache/flink/cdc/connectors/starrocks/sink/StarRocksPipelineITCase.java
Outdated
Show resolved
Hide resolved
...ks/src/test/java/org/apache/flink/cdc/connectors/starrocks/sink/StarRocksPipelineITCase.java
Outdated
Show resolved
Hide resolved
|
@yuxiqian Thanks for the work. Left some comments. Also cc @lvyanquan |
|
Thanks for @banmoy's kindly review, addressed comments above. |
|
LGTM |
banmoy
approved these changes
Apr 22, 2024
|
Fixed in #3348. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes FLINK-35092.
Currently, Flink CDC does not have any integrated tests for StarRocks pipeline connector which runs on real docker container. Adding one should help improving pipeline connectors' reliability.