[FLINK-35415][base] Fix compatibility with Flink 1.19 #3348
Conversation
|
@lvyanquan PTAL |
...ris/src/test/java/org/apache/flink/cdc/connectors/doris/sink/DorisMetadataApplierITCase.java
Show resolved
Hide resolved
| // during Flink 1.18 to 1.19. Remove this when Flink 1.18 is no longer supported. | ||
| try { | ||
| return (SimpleVersionedSerializer<CommT>) | ||
| sink.getClass().getDeclaredMethod("getCommittableSerializer").invoke(sink); |
There was a problem hiding this comment.
Considering that we have had similar operations before in DataSinkWriterOperator, this change is acceptable for me.
There was a problem hiding this comment.
Yeah, but it's definitely not an encouraged way to play with Flink :( Maybe we can decouple Flink base with specific connectors and distribute CDC with various Flink versions respectively.
There was a problem hiding this comment.
+1, distribute CDC with various Flink versions in the future is recommended just like other flink external connectors
|
Thanks for @lvyanquan's review, I've split out commits based on FLINK ticket. |
|
Pushed another commit to resolve CI issue, could @leonardBang please re-trigger the CI? Thanks! |
...ris/src/test/java/org/apache/flink/cdc/connectors/doris/sink/DorisMetadataApplierITCase.java
Show resolved
Hide resolved
...test/java/org/apache/flink/cdc/connectors/starrocks/sink/StarRocksMetadataApplierITCase.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Thanks @yuxiqian for the nice work, the change looks good to me. I left minor comments. It will better if you can organize the commits to make each main change more clear e.g. bump flink version could be in one separate commit, fix sink compatibility could be in another commit, and add e2e case could be in another commit.
...omposer/src/main/java/org/apache/flink/cdc/composer/flink/translator/DataSinkTranslator.java
Outdated
Show resolved
Hide resolved
| // during Flink 1.18 to 1.19. Remove this when Flink 1.18 is no longer supported. | ||
| try { | ||
| return (SimpleVersionedSerializer<CommT>) | ||
| sink.getClass().getDeclaredMethod("getCommittableSerializer").invoke(sink); |
There was a problem hiding this comment.
+1, distribute CDC with various Flink versions in the future is recommended just like other flink external connectors
...omposer/src/main/java/org/apache/flink/cdc/composer/flink/translator/DataSinkTranslator.java
Outdated
Show resolved
Hide resolved
|
Done, seems I messed up the commit history during last rebase... Fixed it. |
This closes FLINK-35092, FLINK-35120, FLINK-35316, FLINK-35415.
This is a temporary workaround to avoid breaking compatibility with Flink 1.19. Proposal about upgrading Flink base (FLINK-35385) could be implemented later.