Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-35120][doris] Add Doris integration test cases #3227

Closed
wants to merge 4 commits into from

Conversation

yuxiqian
Copy link
Contributor

@yuxiqian yuxiqian commented Apr 16, 2024

This closes FLINK-35120.

Currently, Flink CDC Doris pipeline connector has very limited test cases (which only covers row convertion). This PR adds two integration test cases for both data pipeline and metadata applier, which should help improving connector's reliability.

Case testDorisAlterColumnType is currently skipped, since #3215 has not been merged yet.

@yuxiqian
Copy link
Contributor Author

cc @PatrickRen

@yuxiqian yuxiqian force-pushed the FLINK-35120 branch 3 times, most recently from b673f40 to a18c1ed Compare April 17, 2024 08:06
@leonardBang
Copy link
Contributor

The CI failed, could you take a look ? @yuxiqian

@yuxiqian
Copy link
Contributor Author

@leonardBang Seems it's flink-cdc-pipeline-connector-values test that keeps failing recently. Will investigate this.

@JNSimba
Copy link
Member

JNSimba commented Apr 22, 2024

It seems that some codes are duplicated with pr #3222

@yuxiqian
Copy link
Contributor Author

yuxiqian commented Apr 22, 2024

@JNSimba Thanks for pointing it out, #3215 and #3224 share changes by extending DorisSchemaChangeManager. I could rebase after merge one / combine them into one PR. WDYT?

@yuxiqian yuxiqian force-pushed the FLINK-35120 branch 2 times, most recently from 16c8a20 to 239e30c Compare April 23, 2024 03:58
@yuxiqian
Copy link
Contributor Author

yuxiqian commented Jun 6, 2024

Fixed in #3348.

@yuxiqian yuxiqian closed this Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants