-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-35120][doris] Add Doris integration test cases #3227
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc @PatrickRen |
yuxiqian
force-pushed
the
FLINK-35120
branch
3 times, most recently
from
April 17, 2024 08:06
b673f40
to
a18c1ed
Compare
The CI failed, could you take a look ? @yuxiqian |
@leonardBang Seems it's |
It seems that some codes are duplicated with pr #3222 ? |
yuxiqian
force-pushed
the
FLINK-35120
branch
2 times, most recently
from
April 23, 2024 03:58
16c8a20
to
239e30c
Compare
yuxiqian
commented
Apr 23, 2024
...-doris/src/test/java/org/apache/flink/cdc/connectors/doris/sink/utils/DorisSinkTestBase.java
Show resolved
Hide resolved
Fixed in #3348. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes FLINK-35120.
Currently, Flink CDC Doris pipeline connector has very limited test cases (which only covers row convertion). This PR adds two integration test cases for both data pipeline and metadata applier, which should help improving connector's reliability.
Case
testDorisAlterColumnType
is currently skipped, since #3215 has not been merged yet.