[FLINK-30426][Archunit] Set archRule.failOnEmptyShould = false to ret…

…urn old behavior. This closes #7
apache · Dec 15, 2022 · d82256b · d82256b
1 parent 34dd86f
commit d82256b
Show file tree

Hide file tree

Showing 9 changed files with 11 additions and 3 deletions.
diff --git a/flink-connector-pulsar/archunit-violations/2a4fcdd8-60e4-4082-b57b-556a8f752e25 b/flink-connector-pulsar/archunit-violations/2a4fcdd8-60e4-4082-b57b-556a8f752e25
diff --git a/flink-connector-pulsar/archunit-violations/3d200b76-6b88-4f90-b43e-9b162ed73d16 b/flink-connector-pulsar/archunit-violations/3d200b76-6b88-4f90-b43e-9b162ed73d16
diff --git a/flink-connector-pulsar/archunit-violations/6a91e845-4388-460c-a448-42f7c0045e63 b/flink-connector-pulsar/archunit-violations/6a91e845-4388-460c-a448-42f7c0045e63
diff --git a/flink-connector-pulsar/archunit-violations/7e457e8d-a085-43cc-868c-fba88916032a b/flink-connector-pulsar/archunit-violations/7e457e8d-a085-43cc-868c-fba88916032a
diff --git a/flink-connector-pulsar/archunit-violations/a1d4eff3-5439-411c-9c89-a80f3ff0241d b/flink-connector-pulsar/archunit-violations/a1d4eff3-5439-411c-9c89-a80f3ff0241d
diff --git a/flink-connector-pulsar/archunit-violations/aa1707ac-09b7-4467-973b-7223857d3409 b/flink-connector-pulsar/archunit-violations/aa1707ac-09b7-4467-973b-7223857d3409
diff --git a/flink-connector-pulsar/archunit-violations/stored.rules b/flink-connector-pulsar/archunit-violations/stored.rules
@@ -1,4 +1,10 @@
 #
-#Thu Mar 03 12:42:13 CST 2022
-Tests\ inheriting\ from\ AbstractTestBase\ should\ have\ name\ ending\ with\ ITCase=3ac3a1dc-681f-4213-9990-b7b3298a20bc
+#Thu Dec 15 11:39:06 CET 2022
+Return\ and\ argument\ types\ of\ methods\ annotated\ with\ @Public\ must\ be\ annotated\ with\ @Public.=2a4fcdd8-60e4-4082-b57b-556a8f752e25
+Connector\ production\ code\ must\ not\ depend\ on\ non-public\ API\ outside\ of\ connector\ packages=3d200b76-6b88-4f90-b43e-9b162ed73d16
 ITCASE\ tests\ should\ use\ a\ MiniCluster\ resource\ or\ extension=f4d91193-72ba-4ce4-ad83-98f780dce581
+Production\ code\ must\ not\ call\ methods\ annotated\ with\ @VisibleForTesting=aa1707ac-09b7-4467-973b-7223857d3409
+Tests\ inheriting\ from\ AbstractTestBase\ should\ have\ name\ ending\ with\ ITCase=3ac3a1dc-681f-4213-9990-b7b3298a20bc
+Options\ for\ connectors\ and\ formats\ should\ reside\ in\ a\ consistent\ package\ and\ be\ public\ API.=7e457e8d-a085-43cc-868c-fba88916032a
+Return\ and\ argument\ types\ of\ methods\ annotated\ with\ @PublicEvolving\ must\ be\ annotated\ with\ @Public(Evolving).=a1d4eff3-5439-411c-9c89-a80f3ff0241d
+Classes\ in\ API\ packages\ should\ have\ at\ least\ one\ API\ visibility\ annotation.=6a91e845-4388-460c-a448-42f7c0045e63
diff --git a/flink-connector-pulsar/src/test/resources/archunit.properties b/flink-connector-pulsar/src/test/resources/archunit.properties
@@ -29,3 +29,5 @@ freeze.store.default.allowStoreUpdate=true
 #freeze.refreeze=true
 
 freeze.store.default.path=archunit-violations
+
+archRule.failOnEmptyShould = false
diff --git a/pom.xml b/pom.xml
@@ -61,7 +61,7 @@ under the License.
         <junit4.version>4.13.2</junit4.version>
         <junit5.version>5.9.1</junit5.version>
         <assertj.version>3.23.1</assertj.version>
-        <archunit.version>0.22.0</archunit.version>
+        <archunit.version>1.0.0</archunit.version>
         <testcontainers.version>1.17.2</testcontainers.version>
         <mockito.version>2.21.0</mockito.version>