Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish maven artifact containing shaded sources #25

Open
zentol opened this issue Aug 14, 2017 · 3 comments
Open

Publish maven artifact containing shaded sources #25

zentol opened this issue Aug 14, 2017 · 3 comments
Assignees

Comments

@zentol
Copy link
Contributor

zentol commented Aug 14, 2017

When working against the shaded dependencies it is not possible to jump to the source of a class, since we don't build source jars.

The source jars can be created by adding the following lines to the maven-shade-plugin configuration:

<createSourcesJar>true</createSourcesJar>
<shadeSourcesContent>true</shadeSourcesContent>

This is mostly blocked by legal questions:

  • Do we have to modify the release process for these jars?
    • Do we have to vote on the shaded source release?
    • Do we have to modify NOTICE/LICENSE files?
  • Are we allowed to publish a sources jar that isn't actually the source of the project?
  • Are we allowed to publish a sources jar that not necessarily can be compiled to the binary?
    • If the shaded source and binary are the result of 2 separate shading processes we can't guarantee it.
@zentol zentol added this to the 2.0 Release milestone Aug 14, 2017
@zentol zentol self-assigned this Aug 14, 2017
zentol added a commit to zentol/flink-shaded that referenced this issue Aug 28, 2017
zentol added a commit to zentol/flink-shaded that referenced this issue Aug 28, 2017
zentol added a commit to zentol/flink-shaded that referenced this issue Aug 28, 2017
zentol added a commit to zentol/flink-shaded that referenced this issue Aug 28, 2017
zentol added a commit to zentol/flink-shaded that referenced this issue Aug 28, 2017
@zentol zentol removed this from the 2.0 Release milestone Feb 28, 2018
@pnowojski
Copy link
Contributor

Have we asked Apache's legal team about that?

@kennknowles
Copy link
Member

Have you now? If there is a Jira can you link to it?

@peizhouyu
Copy link

peizhouyu commented Oct 17, 2019

Can we add some links to link the corresponding dependencies to the source on Github ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants