[FLINK-14316] Properly manage rpcConnection in JobManagerLeaderListener under leader change #11603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er under leader change This commit changes how the rpcConnection is managed in JobManagerLeaderListener under leader change. This component clears now the fields rpcConnection and currentJobMasterId if the leader loses leadership. Moreover, it only restarts a connection attempt if the leader session id is new.
|
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 34d7bb3 (Wed Apr 15 11:39:24 UTC 2020) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
zentol
approved these changes
Apr 1, 2020
| } | ||
| // check whether we are already connecting to this leader | ||
| if (Objects.equals(jobMasterId, currentJobMasterId)) { | ||
| LOG.debug("Trying already connecting to leader of job {}. Ignoring duplicate leader information.", jobId); |
There was a problem hiding this comment.
Reads a bit weird? How about "Ongoing attempt to connect to leader of job{}. ..."
There was a problem hiding this comment.
Good point. Will update it.
|
Thanks for the review @zentol. I've addressed your comment. Merging this PR now. The failing test case seems to be unrelated (blink planner). |
KarmaGYZ
pushed a commit
to KarmaGYZ/flink
that referenced
this pull request
Apr 10, 2020
…er under leader change This commit changes how the rpcConnection is managed in JobManagerLeaderListener under leader change. This component clears now the fields rpcConnection and currentJobMasterId if the leader loses leadership. Moreover, it only restarts a connection attempt if the leader session id is new. This closes apache#11603.
leonardBang
pushed a commit
to leonardBang/flink
that referenced
this pull request
Apr 10, 2020
…er under leader change This commit changes how the rpcConnection is managed in JobManagerLeaderListener under leader change. This component clears now the fields rpcConnection and currentJobMasterId if the leader loses leadership. Moreover, it only restarts a connection attempt if the leader session id is new. This closes apache#11603.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This commit changes how the rpcConnection is managed in JobManagerLeaderListener under leader change.
This component clears now the fields rpcConnection and currentJobMasterId if the leader loses leadership.
Moreover, it only restarts a connection attempt if the leader session id is new.
Verifying this change
JobLeaderServiceTest.canReconnectToOldLeaderWithSameLeaderAddressDoes this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation