[FLINK-7815] Remove grouping from MultipleJobsDetails #4806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillrohrmann
force-pushed
the
refactorMultipleJobsDetails
branch
2 times, most recently
from
2317cf4
to
fd56f98
Compare
tillrohrmann
force-pushed
the
refactorMultipleJobsDetails
branch
2 times, most recently
from
939a0d1
to
8d642ee
Compare
tillrohrmann
force-pushed
the
refactorMultipleJobsDetails
branch
from
587da63
to
0403a54
Compare
|
Thanks for your review @zentol. Rebased onto the latest master. Once Travis gives green light, I'll merge this PR. |
tillrohrmann
force-pushed
the
refactorMultipleJobsDetails
branch
3 times, most recently
from
de55dff
to
f72c34f
Compare
The AkkaOptions.RETRY_GATE_CLOSED_FOR allows to configure how long a remote ActorSystem is gated in case of a connection loss. The default value is set to 50 ms. This closes apache#4903.
HandlerUtils#sendResponse now accepts a map of additional http response headers and their values. This allows to set additional headers such as the ACCESS_CONTROL_ALLOW_ORIGIN header and its value. This closes apache#4859.
Send dataPort and HardwareDescription to RM Instantiate RM leader retriever
…y.TaskManagersHandler This closes apache#4824.
…sages to rest.messages.taskmanager Move TaskManager messages to rest.messages.taskmanager Move TaskManager message tests to rest.messages.taskmanager
Pass MetricQueryServiceRetriever to DispatcherRestEndpoint This closes apache#4862.
… array Fix failing WebFrontendITCase
Add JobID(De)Serializer and JobVertexID(De)Serializer for jackson This closes apache#4884.
…overview Rename CurrentJobsOverviewHandler to JobsOverviewHandler Change paths Remove joboverview/running and joboverview/completed from JobsOverviewHandler Adapt web ui files Update rest_api to reflect new REST call /jobs This changes apache#4805.
With this commit the MultipleJobsDetails instance only contains a list of all jobs which could be retrieved from the cluster. With this change it is the responsibility of the web ui to group the jobs into running and finished jobs. Adapt jobs.svc.coffee script to group list of jobs into running and finished jobs This closes apache#4806.
tillrohrmann
force-pushed
the
refactorMultipleJobsDetails
branch
from
f72c34f
to
531dfa9
Compare
tillrohrmann
added a commit
to tillrohrmann/flink
that referenced
this pull request
Nov 6, 2017
With this commit the MultipleJobsDetails instance only contains a list of all jobs which could be retrieved from the cluster. With this change it is the responsibility of the web ui to group the jobs into running and finished jobs. Adapt jobs.svc.coffee script to group list of jobs into running and finished jobs This closes apache#4806.
tillrohrmann
added a commit
to tillrohrmann/flink
that referenced
this pull request
Nov 7, 2017
With this commit the MultipleJobsDetails instance only contains a list of all jobs which could be retrieved from the cluster. With this change it is the responsibility of the web ui to group the jobs into running and finished jobs. Adapt jobs.svc.coffee script to group list of jobs into running and finished jobs This closes apache#4806.
GJL
pushed a commit
to GJL/flink
that referenced
this pull request
Nov 8, 2017
With this commit the MultipleJobsDetails instance only contains a list of all jobs which could be retrieved from the cluster. With this change it is the responsibility of the web ui to group the jobs into running and finished jobs. Adapt jobs.svc.coffee script to group list of jobs into running and finished jobs This closes apache#4806.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
With this commit the MultipleJobsDetails instance only contains a list of all jobs
which could be retrieved from the cluster. With this change it is the responsibility
of the web ui to group the jobs into running and finished jobs.
Brief change log
MultipleJobsDetailsto contain a single list of all retrieved jobsVerifying this change
This change has been manually tested.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation