-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-8744][docs] Generate "Common Option" section #5843
Conversation
Looks pretty good. Is there a way we can "sort" the common options? Something like
|
they should be sorted alphabetically based on the key, but i now see that this isn't actually the case. I'm not sure if I can easily add the kind of sorting you're asking for as that would require the generator to know about the semantics of an option ("oh, this is a port option, but that one is about memory!"). |
One could add an int to the annotation, as "priority / position" and sort by that. I think it was nice for users that the most common options (the ones you need first) were at the top of the list. Out of curiosity, what happens to options like |
For |
@StephanEwen The options are now sorted. |
LGTM 👍 |
merging. |
What is the purpose of the change
With this PR the "Common Options" section is now generated by the
ConfigOptionDocsGenerator
.Brief change log
Verifying this change
ConfigOptionsDocGeneratorTest#testCommonOptions
ConfigOptionsDocsCompletenessTest#testCommonSectionCompleteness