[FLINK-9286][docs] Update classloading docs #5948
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StephanEwen
reviewed
May 3, 2018
| be resolved through the parent ClassLoader first, although you can also configure this via | ||
| `classloader.parent-first-patterns` (see [config](../ops/config.html)) | ||
| [classloader.parent-first-patterns-default](../ops/config.html#classloader-parent-first-patterns-default). |
There was a problem hiding this comment.
How about referencing `classloader.parent-first-patterns-additional here instead? The recommendation is not to change the value for "default"...
There was a problem hiding this comment.
This particular sentence is about removing Flink from the paren-first pattern, for which you must modify the default.
|
I agree that the default shouldn't be listed in the common section. The "Common Options" section will be reworked soon to also be generated (in this PR). I suggest to look at which options should be listed there after the PR is merged. |
|
Thanks. Will merge this, possibly add one more sentence in the process... |
StephanEwen
pushed a commit
to StephanEwen/flink
that referenced
this pull request
May 24, 2018
sampathBhat
pushed a commit
to sampathBhat/flink
that referenced
this pull request
Jul 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR updates the
Configuring ClassLoader Resolution Ordersection of theDebugging Classloadingpage.Brief change log
classloader.parent-first-patternkey