GORA-437 implement couchdb datastore #74
Conversation
| @@ -690,6 +690,7 @@ else if (effectiveSchema.getType() == Type.MAP) { | |||
| } | |||
| // continue like a regular top-level union | |||
| case RECORD: | |||
| //TODO duplicated code @see org.apache.gora.util.IOUtils#serialize() | |||
There was a problem hiding this comment.
What do you suggest implementing here? Please open a ticket in Jira.
There was a problem hiding this comment.
I have created a new issue : https://issues.apache.org/jira/browse/GORA-487
There was a problem hiding this comment.
I have created new pull request for it as follow: #76
|
In general this is looking very good. Can you please go through and address my comments? Can you also ensure that for every new method that you've added you also add a Javadoc comment?
Thanks @cguzel great work :) |
|
@cguzel can you please rebase against master? |
|
@lewismc How to create documentation? I don't know how to edit this page : http://gora.apache.org/current/index.html#gora-modules |
|
I added a patch for documentation https://issues.apache.org/jira/browse/GORA-489 @lewismc |
|
|
||
| final CouchDBStore store; | ||
|
|
||
| public CouchDBQuery() { |
| private ObjectMapper instance; | ||
| private boolean writeDatesAsTimestamps = false; | ||
|
|
||
| public synchronized ObjectMapper createObjectMapper() { |
,added a new store for gora as gora-couchdb ,added javadocs ,bugfixed
|
I have added maven profile in gora-couchdb pom.xml. So The tests skip by default. If you use java 1.8 and docker, you build and run tests using maven profile as "mvn clean install -P couchdb-with-test". |
|
I have added new javadocs. |
|
Hey@cguzel, FYI TestContainers dependency has "compile" scope. You probably want to move it to "test" scope :) |
|
Thanks @bsideup . I will check it. |
|
@cguzel we're planning to add Apache Gora to TestContainers' "who is using?" list, don't you mind? |
|
Sorry. Yes true. I corrected the mistake. |
|
@lewismc may I ask you to comment or react with " 👍 " on testcontainers/testcontainers-java#296 ? :) |
This pull request is for GORA-437. I developed couchdb store for gora. I added javadocs and test codes. The tests required couchdb instance. But I wondered how to start couchdb server programmatically using java. So, I sent an email to couchDB userlist. They suggest that using docker. Then I use docker programmaticaly with https://github.com/testcontainers/testcontainers-java . All test cases passed with this approach. But this caused dependece to docker and jdk 1.8 . So this pull request doesn't merge to master.
We should look another solution. Maybe using mockito for testing or another idea?
All tests are passed on my local. I ignored 3 tests. You can see them in my test code.