Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GORA-487 Edited AccumuloStore.java duplicate code lines #76

Merged
merged 2 commits into from
Aug 19, 2016

Conversation

cguzel
Copy link
Member

@cguzel cguzel commented Aug 17, 2016

The code lines have already been in org.apache.gora.util.IOUtils

@lewismc
Copy link
Member

lewismc commented Aug 18, 2016

There were other instances of this as well @cguzel . Is that correct? Thanks for logging this issue.

@cguzel
Copy link
Member Author

cguzel commented Aug 19, 2016

I have edited AvroUtils.java and AccumuloStore.java. I have reviewed the other instances, any changes will not do for them. @lewismc

@asfgit asfgit merged commit 4192c87 into apache:master Aug 19, 2016
@lewismc
Copy link
Member

lewismc commented Aug 19, 2016

OK
Code is good and tests well locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants