New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-3809. Make number of open containers on a datanode a function of no of volumes reported by it. #1081
Conversation
… no of volumes reported by it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, based on my understanding this is a good step forward.
Thanks to create this @bshashikant
Let's merge it after a green build.
...op-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/pipeline/SCMPipelineManager.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. Few checkstyle issues need to be addressed and then we are good to merge.
hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/MockNodeManager.java
Outdated
Show resolved
Hide resolved
checkstyle issues have been addressed
Thanks @bshashikant for the contribution, @elek and @dineshchitlangia for the review. Merged to |
* master: (55 commits) HDDS-4052. Remove master/slave terminology from Ozone (apache#1281) HDDS-4047. OzoneManager met NPE exception while getServiceList (apache#1277) HDDS-3990. Test Kubernetes examples with acceptance tests (apache#1223) HDDS-4045. Add more ignore rules to the RAT ignore list (apache#1273) HDDS-3970. Enabling TestStorageContainerManager with all failures addressed (apache#1257) HDDS-4033. Make the acceptance test reports hierarchical (apache#1263) HDDS-3423. Enabling TestContainerReplicationEndToEnd and addressing failures (apache#1260) HDDS-4027. Suppress ERROR message when SCM attempt to create additional pipelines. (apache#1265) HDDS-4024. Avoid while loop too soon when exception happen (apache#1253) HDDS-3809. Make number of open containers on a datanode a function of no of volumes reported by it. (apache#1081) HDDS-4019. Show the storageDir while need init om or scm (apache#1248) HDDS-3511. Fix javadoc comment in OmMetadataManager (apache#1247) HDDS-4041. Ozone /conf endpoint triggers kerberos replay error when SPNEGO is enabled. (apache#1267) HDDS-4031. Run shell tests in CI (apache#1261) HDDS-4038. Eliminate GitHub check warnings (apache#1268) HDDS-4011. Update S3 related documentation. (apache#1245) HDDS-4030. Remember the selected columns and make the X-axis scrollable in recon datanodes UI (apache#1259) HDDS-4032. Run author check without docker (apache#1262) HDDS-4026. Dir rename failed when sets 'ozone.om.enable.filesystem.paths' to true (apache#1256) HDDS-4017. Acceptance check may run against wrong commit (apache#1249) ...
… no of volumes reported by it. (#1081)
… no of volumes reported by it. (apache#1081)
What changes were proposed in this pull request?
Added logic to take into account max no of healthy disks reported among the sets
of datanodes of a pipeline to get the total no of open containers per pipeline.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3809
How was this patch tested?
Added unit tests.